[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=543443&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543443
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/21 08:33
Start Date: 28/Jan/21 08:33
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #13658:
URL: https://github.com/apache/beam/pull/13658#discussion_r565904435
##########
File path: runners/flink/flink_runner.gradle
##########
@@ -137,11 +138,9 @@ dependencies {
compile project(":runners:java-job-service")
compile project(":sdks:java:extensions:google-cloud-platform-core")
compile library.java.vendored_grpc_1_26_0
- compile library.java.jackson_annotations
compile library.java.slf4j_api
compile library.java.joda_time
compile library.java.args4j
- compile "org.apache.flink:flink-clients_2.11:$flink_version"
Review comment:
@ibzib I noticed this while testing the 2.28.0 SNAPSHOTs. Now from the
user side I am forced to pass this dependency. Is this a regression? if this is
intended (I doubt it) we should probably announce it in CHANGES.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543443)
Time Spent: 99h 20m (was: 99h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 99h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
