[
https://issues.apache.org/jira/browse/BEAM-11705?focusedWorklogId=543840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543840
]
ASF GitHub Bot logged work on BEAM-11705:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/21 19:59
Start Date: 28/Jan/21 19:59
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13827:
URL: https://github.com/apache/beam/pull/13827#issuecomment-769338906
# [Codecov](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=h1) Report
> Merging
[#13827](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=desc) (7962018)
into
[master](https://codecov.io/gh/apache/beam/commit/1fbf45c53824c94a1502f6cfa4f60299a4d1c030?el=desc)
(1fbf45c) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13827 +/- ##
==========================================
+ Coverage 82.77% 82.82% +0.05%
==========================================
Files 466 466
Lines 57558 57595 +37
==========================================
+ Hits 47645 47705 +60
+ Misses 9913 9890 -23
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
| `91.91% <0.00%> (-2.21%)` | :arrow_down: |
|
[.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==)
| `89.11% <0.00%> (-0.62%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `91.56% <0.00%> (-0.42%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
| `91.37% <0.00%> (-0.08%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
| `75.07% <0.00%> (-0.04%)` | :arrow_down: |
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `94.60% <0.00%> (ø)` | |
|
[...apache\_beam/portability/api/beam\_runner\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjIucHk=)
| `100.00% <0.00%> (ø)` | |
|
[...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=)
| `74.55% <0.00%> (ø)` | |
|
[...e\_beam/portability/api/beam\_runner\_api\_pb2\_urns.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvYXBpL2JlYW1fcnVubmVyX2FwaV9wYjJfdXJucy5weQ==)
| `100.00% <0.00%> (ø)` | |
|
[...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==)
| `89.87% <0.00%> (ø)` | |
| ... and [7
more](https://codecov.io/gh/apache/beam/pull/13827/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=footer). Last
update
[29b9542...7962018](https://codecov.io/gh/apache/beam/pull/13827?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 543840)
Time Spent: 50m (was: 40m)
> Write to bigquery always assigns unique insert id per row causing performance
> issue
> -----------------------------------------------------------------------------------
>
> Key: BEAM-11705
> URL: https://issues.apache.org/jira/browse/BEAM-11705
> Project: Beam
> Issue Type: Improvement
> Components: io-py-gcp
> Reporter: Ning Kang
> Assignee: Pablo Estrada
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The `ignore_insert_id` argument in BigQuery IO Connector
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py#L1471
> does not take effect.
> Because the implementation of sending insert rows request always uses an auto
> generated uuid even when the insert_ids is set to None when
> `ignore_insert_id` is True:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery_tools.py#L1062
> The implementation should explicitly set insert_id as None instead of using a
> generated uuid, an example:
> https://github.com/googleapis/python-bigquery/blob/master/samples/table_insert_rows_explicit_none_insert_ids.py#L33
> An unique insert id per row would make the streaming inserts very slow.
> Additionally, the `DEFAULT_SHARDS_PER_DESTINATION` doesn't seem to take any
> effect when `ignore_insert_id` is True in the implementation because it
> skipped the `ReshufflePerKey`
> (https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/bigquery.py#L1422).
> When `ignore_insert_id` is True, we seem to lost the batch size control?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
