[
https://issues.apache.org/jira/browse/BEAM-11589?focusedWorklogId=544337&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544337
]
ASF GitHub Bot logged work on BEAM-11589:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/21 16:20
Start Date: 29/Jan/21 16:20
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13837:
URL: https://github.com/apache/beam/pull/13837#discussion_r566930630
##########
File path: settings.gradle.kts
##########
@@ -0,0 +1,226 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+plugins {
+ id("com.gradle.enterprise") version "3.4.1" apply false
+}
Review comment:
Could you try to get git to track this as a moved file (settings.gradle
-> settings.gradle.kts) rather than a separate remove and an add? There are
some tips about it
[here](https://stackoverflow.com/questions/433111/how-to-make-git-mark-a-deleted-and-a-new-file-as-a-file-move)
One of the suggestions is to first make a commit that moves the file, with
no changes, then make a second commit that modifies it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 544337)
Time Spent: 2h 20m (was: 2h 10m)
> Migrate Gradle scripts from Groovy to Kotlin DSL.
> -------------------------------------------------
>
> Key: BEAM-11589
> URL: https://issues.apache.org/jira/browse/BEAM-11589
> Project: Beam
> Issue Type: Wish
> Components: build-system
> Reporter: Kyle Weaver
> Priority: P2
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Our current Gradle build scripts/configs use the traditional Groovy DSL.
> Gradle supports a newer Kotlin DSL, and Kotlin is (in my biased opinion) a
> better language than Groovy.
> https://docs.gradle.org/nightly/userguide/migrating_from_groovy_to_kotlin_dsl.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
