[
https://issues.apache.org/jira/browse/BEAM-5644?focusedWorklogId=195289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195289
]
ASF GitHub Bot logged work on BEAM-5644:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/19 18:34
Start Date: 06/Feb/19 18:34
Worklog Time Spent: 10m
Work Description: akedin commented on pull request #7745: [BEAM-5644]
make Planner configurable
URL: https://github.com/apache/beam/pull/7745#discussion_r254390846
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamSqlEnv.java
##########
@@ -49,19 +46,19 @@
@Experimental
public class BeamSqlEnv {
final JdbcConnection connection;
- final BeamQueryPlanner planner;
+ final QueryPlanner planner;
- private BeamSqlEnv(TableProvider tableProvider) {
- connection = JdbcDriver.connect(tableProvider);
- planner = new BeamQueryPlanner(connection);
+ private BeamSqlEnv(JdbcConnection connection, QueryPlanner planner) {
+ this.connection = connection;
+ this.planner = planner;
}
public static BeamSqlEnv readOnly(String tableType, Map<String,
BeamSqlTable> tables) {
return withTableProvider(new ReadOnlyTableProvider(tableType, tables));
}
public static BeamSqlEnv withTableProvider(TableProvider tableProvider) {
- return new BeamSqlEnv(tableProvider);
+ return BeamSqlEnvBuilder.builder(tableProvider).build();
Review comment:
nit:I think the pattern is to have a `static BeamSqlEnv.builder()` method
that would call a protected constructor on the builder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195289)
> make Planner configurable
> --------------------------
>
> Key: BEAM-5644
> URL: https://issues.apache.org/jira/browse/BEAM-5644
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
> We can make planner configurable here:
> [BeamQueryPlanner.java#L145|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/BeamQueryPlanner.java#L145]
>
> By doing so, we can have different planner implementation to support
> different SQL dialect.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
