[
https://issues.apache.org/jira/browse/BEAM-11700?focusedWorklogId=544534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544534
]
ASF GitHub Bot logged work on BEAM-11700:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/21 22:42
Start Date: 29/Jan/21 22:42
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13824:
URL: https://github.com/apache/beam/pull/13824#issuecomment-768541456
# [Codecov](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=h1) Report
> Merging
[#13824](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=desc) (994dc50)
into
[master](https://codecov.io/gh/apache/beam/commit/297548718cc69ddd30f8c7d1aec6285d6e13ad8c?el=desc)
(2975487) will **increase** coverage by `0.03%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13824 +/- ##
==========================================
+ Coverage 82.78% 82.81% +0.03%
==========================================
Files 466 466
Lines 57557 57560 +3
==========================================
+ Hits 47647 47669 +22
+ Misses 9910 9891 -19
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==)
| `89.87% <ø> (ø)` | |
|
[...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=)
| `75.53% <80.00%> (+0.97%)` | :arrow_up: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `86.45% <0.00%> (-1.05%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=)
| `96.29% <0.00%> (-0.53%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `91.56% <0.00%> (-0.42%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `89.69% <0.00%> (-0.16%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.83% <0.00%> (ø)` | |
|
[.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/13824/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==)
| `92.78% <0.00%> (+3.05%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=footer). Last
update
[280107a...b81fb7a](https://codecov.io/gh/apache/beam/pull/13824?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 544534)
Time Spent: 1h 40m (was: 1.5h)
> Optimizations skipped in PortableRunner when pre_optimize is 'default' or
> 'all'
> -------------------------------------------------------------------------------
>
> Key: BEAM-11700
> URL: https://issues.apache.org/jira/browse/BEAM-11700
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Yifan Mai
> Assignee: Yifan Mai
> Priority: P2
> Fix For: 2.28.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> An indentation error in portable_runner.py is causing optimizations to not
> run when pre_optimize is set to default or all. This was broken by
> [#13573|https://github.com/apache/beam/pull/13573].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
