[
https://issues.apache.org/jira/browse/BEAM-11715?focusedWorklogId=544615&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-544615
]
ASF GitHub Bot logged work on BEAM-11715:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/21 01:10
Start Date: 30/Jan/21 01:10
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#13851:
URL: https://github.com/apache/beam/pull/13851#discussion_r567171701
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations_test.py
##########
@@ -227,6 +232,53 @@ def assert_is_topologically_sorted(transform_id,
visited_pcolls):
assert_is_topologically_sorted(
optimized_pipeline_proto.root_transform_ids[0], set())
+ @attr('ValidatesRunner')
+ def test_run_packable_combine_per_key(self):
+ class MultipleCombines(beam.PTransform):
+ def expand(self, pcoll):
+ assert_that(
Review comment:
How do we confirm that combiner packing was triggered here ? This would
pass even without combiner packing, right ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 544615)
Remaining Estimate: 0h
Time Spent: 10m
> Combiner packing creates an incorrect proto
> -------------------------------------------
>
> Key: BEAM-11715
> URL: https://issues.apache.org/jira/browse/BEAM-11715
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Yifan Mai
> Priority: P0
> Fix For: 2.28.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Seems like optimization creates a CombinePerKey transform that does not have
> any sub-transforms. We should fix this by preserving the old structure for
> CombinePerKey (GBK+CombineValues composite).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
