[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=545672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545672
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/21 22:43
Start Date: 01/Feb/21 22:43
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13800:
URL: https://github.com/apache/beam/pull/13800#discussion_r568191648
##########
File path: sdks/java/io/snowflake/expansion-service/build.gradle
##########
@@ -32,8 +32,8 @@ description = "Apache Beam :: SDKs :: Java :: IO :: Snowflake
::Expansion Servic
ext.summary = "Expansion service serving Snowflake IO"
dependencies {
- compile project(":sdks:java:expansion-service")
- compile project(":sdks:java:io:snowflake")
+ runtimeOnly project(":sdks:java:expansion-service")
Review comment:
Let's just leave these as compile + permitUnusedDeclared to be safe.
##########
File path: sdks/java/io/snowflake/build.gradle
##########
@@ -27,19 +28,17 @@ ext.summary = "IO to read and write on Snowflake."
dependencies {
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
- compile project(path: ":sdks:java:extensions:google-cloud-platform-core")
Review comment:
On second thought, let's just leave this as compile +
permitUnusedDeclared to be safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 545672)
Time Spent: 103h 50m (was: 103h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 103h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
