[
https://issues.apache.org/jira/browse/BEAM-5191?focusedWorklogId=195387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195387
]
ASF GitHub Bot logged work on BEAM-5191:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/19 22:17
Start Date: 06/Feb/19 22:17
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #7061: [BEAM-5191]
Support for BigQuery clustering
URL: https://github.com/apache/beam/pull/7061#discussion_r254474739
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BatchLoads.java
##########
@@ -292,7 +292,7 @@ private WriteResult
expandTriggered(PCollection<KV<DestinationT, TableRow>> inpu
.apply(WithKeys.of((Void) null))
.setCoder(
KvCoder.of(
- VoidCoder.of(), KvCoder.of(TableDestinationCoderV2.of(),
StringUtf8Coder.of())))
+ VoidCoder.of(), KvCoder.of(TableDestinationCoderV3.of(),
StringUtf8Coder.of())))
Review comment:
Coder compatibility is unfortunately not well defined. The best assumption
today is that any change to coder is incompatible (Beam needs to define a
better story around updating coders).
I don't think a Nullable field helps here. The nullable coder will still
expect something there, and there will be nothing there.
We need to either:
1. Decide that this is important enough that we are willing to break
update.
2 . Make the use of the new coder somehow contingent on the user using
clustering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195387)
Time Spent: 6h 20m (was: 6h 10m)
> Add support for writing to BigQuery clustered tables
> ----------------------------------------------------
>
> Key: BEAM-5191
> URL: https://issues.apache.org/jira/browse/BEAM-5191
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.6.0
> Reporter: Robert Sahlin
> Assignee: Wout Scheepers
> Priority: Minor
> Labels: features, newbie
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Google recently added support for clustered tables in BigQuery. It would be
> useful to set clustering columns the same way as for partitioning. It should
> support multiple fields (4) for clustering.
> For example:
> [BigQueryIO.Write|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]<[T|https://beam.apache.org/documentation/sdks/javadoc/2.6.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.Write.html]>
> .withClustering(new Clustering().setField("productId").setType("STRING"))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
