[
https://issues.apache.org/jira/browse/BEAM-11657?focusedWorklogId=546691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-546691
]
ASF GitHub Bot logged work on BEAM-11657:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 01:29
Start Date: 03/Feb/21 01:29
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #13782:
URL: https://github.com/apache/beam/pull/13782#issuecomment-771707831
I checked randomly the results of Performance test from other runs and seems
that we have some improvement with this PR.
It LGTM
CC: @boyuanzz @chamikaramj fyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 546691)
Time Spent: 2h (was: 1h 50m)
> Kafka read performance regression due to added header support
> -------------------------------------------------------------
>
> Key: BEAM-11657
> URL: https://issues.apache.org/jira/browse/BEAM-11657
> Project: Beam
> Issue Type: Bug
> Components: io-java-kafka
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Support for headers in KafkaIO reads was recently added:
> https://issues.apache.org/jira/browse/BEAM-10865
> This introduced several reflection calls into the path of advancing
> KafkaUnboundedReader. While separately running benchmarks, I noticed this
> regression.
> Calls currently come from:
> ConsumerSpEL.hasHeaders -> can be cached similar to other booleans
> deserialize key and value methods -> could be avoided in cases where headers
> are not being examined (at a minimum can be avoided for known coders like
> ByteArrayDeserializer)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
