[
https://issues.apache.org/jira/browse/BEAM-9918?focusedWorklogId=546848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-546848
]
ASF GitHub Bot logged work on BEAM-9918:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 04:13
Start Date: 03/Feb/21 04:13
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #13872:
URL: https://github.com/apache/beam/pull/13872#discussion_r569118176
##########
File path: sdks/go/pkg/beam/external_test.go
##########
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package beam
+
+import (
+ "bytes"
+ "context"
+ "strings"
+ "testing"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/graphx"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+ "github.com/apache/beam/sdks/go/pkg/beam/options/jobopts"
+)
+
+func TestExternalTagged(t *testing.T) {
+ urn := "my::test::urn"
+ payload := []byte("expected_payload")
+ inTag := "inTag"
+ outTag := "outTag"
+
+ p := NewPipeline()
+ s := p.Root()
+
+ col := Impulse(s)
+ ft := typex.New(reflectx.ByteSlice)
+ outMap := ExternalTagged(s, urn, payload, map[string]PCollection{inTag:
col}, map[string]FullType{outTag: ft}, true)
+
+ // Validate the in-construction PCollection types for ExternalTagged.
+ if len(outMap) != 1 {
+ t.Fatalf("ExternalTagged = %v, want 1 output with tag %q",
outMap, outTag)
+ }
+ out, ok := outMap[outTag]
+ if !ok {
+ t.Fatalf("ExternalTagged = %v, want 1 output with tag %q",
outMap, outTag)
+ }
+ if !typex.IsEqual(out.Type(), ft) {
+ t.Fatalf("ExternalTagged()[%q].Type() = %v, want %v", outTag,
out.Type(), ft)
+ }
+
+ // Validate the post-construction pipeline protocol buffer contents.
+
+ ctx := context.Background()
+ envUrn := jobopts.GetEnvironmentUrn(ctx)
+ getEnvCfg := jobopts.GetEnvironmentConfig
+ environment, err := graphx.CreateEnvironment(ctx, envUrn, getEnvCfg)
+ if err != nil {
+ t.Fatalf("Couldn't create environment build: %v", err)
+ }
+
+ edges, _, err := p.Build()
+ if err != nil {
+ t.Fatalf("Pipeline couldn't build: %v", err)
+ }
+ pb, err := graphx.Marshal(edges, &graphx.Options{Environment:
environment})
+ if err != nil {
+ t.Fatalf("Couldn't graphx.Marshal edges: %v", err)
+ }
+ components := pb.GetComponents()
+ transforms := components.GetTransforms()
+
+ foundExternalTagged := false
+ for _, transform := range transforms {
+ spec := transform.GetSpec()
Review comment:
This loop seems a bit strangely structured. From what I can tell it's
just searching for the external transform by URN and then doing some checks,
right? You could just put all the checks in the `if strings.Contains` statement
and do all the validation at once, or if you want to avoid indentations, then
reverse it by starting the loop with `if !strings.Contains { continue; }`.
##########
File path: sdks/go/pkg/beam/external_test.go
##########
@@ -0,0 +1,104 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package beam
+
+import (
+ "bytes"
+ "context"
+ "strings"
+ "testing"
+
+ "github.com/apache/beam/sdks/go/pkg/beam/core/runtime/graphx"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/typex"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+ "github.com/apache/beam/sdks/go/pkg/beam/options/jobopts"
+)
+
+func TestExternalTagged(t *testing.T) {
+ urn := "my::test::urn"
+ payload := []byte("expected_payload")
+ inTag := "inTag"
+ outTag := "outTag"
+
+ p := NewPipeline()
+ s := p.Root()
+
+ col := Impulse(s)
+ ft := typex.New(reflectx.ByteSlice)
+ outMap := ExternalTagged(s, urn, payload, map[string]PCollection{inTag:
col}, map[string]FullType{outTag: ft}, true)
+
+ // Validate the in-construction PCollection types for ExternalTagged.
+ if len(outMap) != 1 {
+ t.Fatalf("ExternalTagged = %v, want 1 output with tag %q",
outMap, outTag)
+ }
+ out, ok := outMap[outTag]
+ if !ok {
+ t.Fatalf("ExternalTagged = %v, want 1 output with tag %q",
outMap, outTag)
+ }
+ if !typex.IsEqual(out.Type(), ft) {
+ t.Fatalf("ExternalTagged()[%q].Type() = %v, want %v", outTag,
out.Type(), ft)
+ }
+
+ // Validate the post-construction pipeline protocol buffer contents.
+
+ ctx := context.Background()
+ envUrn := jobopts.GetEnvironmentUrn(ctx)
Review comment:
It seems strange to use actual flags in a unit test unless they're meant
to be set when calling `go test`. If you need the default flags, it seems
better to explicitly set these to the default flag values in this function.
There is the situation where, if the default values are changed and it
breaks this test then it will be caught, but that still feels more like
something for an integration test to catch than a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 546848)
Time Spent: 2h 40m (was: 2.5h)
> Cross-language transforms support for Go SDK
> --------------------------------------------
>
> Key: BEAM-9918
> URL: https://issues.apache.org/jira/browse/BEAM-9918
> Project: Beam
> Issue Type: New Feature
> Components: cross-language, sdk-go
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Daniel Oliveira
> Priority: P3
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> This is an uber issue for tasks related to cross-language transforms support
> for Go SDK. We can create sub-tasks as needed.
> Design Doc:
> [https://docs.google.com/document/d/1h_hQNe4cNPXUtl5hlnH7eqVAfSwBON9hqjCYP0BI4Mo/edit]
>
> cc: [~lostluck]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
