[
https://issues.apache.org/jira/browse/BEAM-11476?focusedWorklogId=547192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547192
]
ASF GitHub Bot logged work on BEAM-11476:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 18:18
Start Date: 03/Feb/21 18:18
Worklog Time Spent: 10m
Work Description: KevinGG commented on pull request #13881:
URL: https://github.com/apache/beam/pull/13881#issuecomment-772717403
> I'm a little wary about this fix, since you said you weren't able to
replicate the flakiness locally and we're not clear exactly how it's failing.
This seems like a reasonable change anyway so we could go ahead and merge it
(except for maybe the test I commented on), but I'd want to keep the jira open
while we monitor for more flakes.
>
> Is there any logging we could add that would help diagnose if this does
happen again? Maybe logging the call site/calling object?
>
> FYI I took a look at the [precommit history for
InteractiveEnvironmentTest](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/testReport/junit/apache_beam.runners.interactive.interactive_environment_test/InteractiveEnvironmentTest/history/)
to see if I could get some more signal.
>
> The only interesting thing I found is that this also happened with
[mocked_atexit](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/3760/testReport/junit/apache_beam.runners.interactive.interactive_environment_test/InteractiveEnvironmentTest/test_cleanup_registered_when_creating_new_env_5/).
Let's keep the Jira open and see if new flakiness occurs. I'll make change
to the recommended test and the atexit register test to also move the patch
inside the test function.
I think the issues are:
1. The global singleton instance `_interactive_beam_env ` (a module
property) is not thread safe in the testing environment on Jenkins.
2. The patch should be limited to the statement that the test cares about to
be resilient to race conditions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 547192)
Time Spent: 2h 10m (was: 2h)
> flaky test: test_track_user_pipeline_cleanup_non_inspectable_pipeline
> ---------------------------------------------------------------------
>
> Key: BEAM-11476
> URL: https://issues.apache.org/jira/browse/BEAM-11476
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Ning Kang
> Priority: P1
> Labels: currently-failing, flake
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Test name:
> apache_beam.runners.interactive.interactive_environment_test.InteractiveEnvironmentTest.test_track_user_pipeline_cleanup_non_inspectable_pipeline
> {code}
> Error Message
> AssertionError: Expected 'cleanup' to not have been called. Called 1 times.
> Stacktrace
> self =
> <apache_beam.runners.interactive.interactive_environment_test.InteractiveEnvironmentTest
> testMethod=test_track_user_pipeline_cleanup_non_inspectable_pipeline>
> mocked_cleanup = <MagicMock name='cleanup' id='140386685111432'>
> @patch(
> 'apache_beam.runners.interactive.interactive_environment'
> '.InteractiveEnvironment.cleanup')
> def test_track_user_pipeline_cleanup_non_inspectable_pipeline(
> self, mocked_cleanup):
> ie._interactive_beam_env = None
> ie.new_env()
> dummy_pipeline_1 = beam.Pipeline()
> dummy_pipeline_2 = beam.Pipeline()
> dummy_pipeline_3 = beam.Pipeline()
> dummy_pipeline_4 = beam.Pipeline()
> dummy_pcoll = dummy_pipeline_4 | beam.Create([1])
> dummy_pipeline_5 = beam.Pipeline()
> dummy_non_inspectable_pipeline = 'dummy'
> ie.current_env().watch(locals())
> from apache_beam.runners.interactive.background_caching_job import
> BackgroundCachingJob
> ie.current_env().set_background_caching_job(
> dummy_pipeline_1,
> BackgroundCachingJob(
> runner.PipelineResult(runner.PipelineState.DONE), limiters=[]))
> ie.current_env().set_test_stream_service_controller(dummy_pipeline_2,
> None)
> ie.current_env().set_cache_manager(
> cache.FileBasedCacheManager(), dummy_pipeline_3)
> ie.current_env().mark_pcollection_computed([dummy_pcoll])
> ie.current_env().set_cached_source_signature(
> dummy_non_inspectable_pipeline, None)
> ie.current_env().set_pipeline_result(
> dummy_pipeline_5,
> runner.PipelineResult(runner.PipelineState.RUNNING))
> > mocked_cleanup.assert_not_called()
> apache_beam/runners/interactive/interactive_environment_test.py:265:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _
> _mock_self = <MagicMock name='cleanup' id='140386685111432'>
> def assert_not_called(_mock_self):
> """assert that the mock was never called.
> """
> self = _mock_self
> if self.call_count != 0:
> msg = ("Expected '%s' to not have been called. Called %s times." %
> (self._mock_name or 'mock', self.call_count))
> > raise AssertionError(msg)
> E AssertionError: Expected 'cleanup' to not have been called.
> Called 1 times.
> /usr/lib/python3.7/unittest/mock.py:792: AssertionError
> {code}
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/3609/
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/3607/
> https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/3593/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
