[ 
https://issues.apache.org/jira/browse/BEAM-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278435#comment-17278435
 ] 

Kenneth Knowles commented on BEAM-11746:
----------------------------------------

This isn't a solution, but two thoughts reading the code around that failure:

1. Failing with just a boolean is blinding us to the problem.
2. A histogram of batch sizes could potentially be clearer than the mere fact 
that one of them was too small or too big
3. Checking {{EVEN_NUM_ELEMENTS / BATCH_SIZE}} is brittle vs measuring the size 
of the actual data. There is nothing in the test that assures the data is 
actually that size.

If it is recent, we may have broken state in the direct runner.

> GroupIntoBatchesTest.testInGlobalWindow flaky
> ---------------------------------------------
>
>                 Key: BEAM-11746
>                 URL: https://issues.apache.org/jira/browse/BEAM-11746
>             Project: Beam
>          Issue Type: Bug
>          Components: test-failures
>            Reporter: Kyle Weaver
>            Priority: P1
>              Labels: flake
>
> https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3078/testReport/junit/org.apache.beam.sdk.transforms/GroupIntoBatchesTest/testInGlobalWindow/history/
> A couple different failures:
> 1. java.lang.AssertionError: Incorrect batch size in one or more elements: 
> null
> https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3078/testReport/junit/org.apache.beam.sdk.transforms/GroupIntoBatchesTest/testInGlobalWindow/
> 2. java.lang.AssertionError: Incorrect collection size: 
> Expected: <2L>
>      but: was <3L>
> https://ci-beam.apache.org/job/beam_PreCommit_Java_Phrase/3075/testReport/junit/org.apache.beam.sdk.transforms/GroupIntoBatchesTest/testInGlobalWindow/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to