[
https://issues.apache.org/jira/browse/BEAM-11424?focusedWorklogId=547773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547773
]
ASF GitHub Bot logged work on BEAM-11424:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/21 18:52
Start Date: 04/Feb/21 18:52
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13565:
URL: https://github.com/apache/beam/pull/13565#discussion_r570462057
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -0,0 +1,42 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy
of
+// the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations
under
+// the License.
+
+$(document).ready(function() {
+ function copy() {
+ $(".copy").click(function(){
+ var
text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ const el=document.createElement('textarea');
+ el.value=text;document.body.appendChild(el);
+ el.select();document.execCommand('copy');
+ document.body.removeChild(el);
+ alert('copied to clipboard');
+ })
+ $(".just-copy").click(function(){
+ var text=$(this).parent().siblings()[0].innerHTML;
+ const el=document.createElement('textarea');
+ el.value=text;document.body.appendChild(el);
+ el.select();document.execCommand('copy');
+ document.body.removeChild(el);
+ alert('copied to clipboard');
Review comment:
This alert is strange to me. It's weird to have to click "OK" after
copying.
Other implementations of this sort of featureu usually pop up a notification
to let you know the content has been copied, but you don't have to acknowledge
it. If it's too much to address this right now let's file a jira about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 547773)
Time Spent: 12h 20m (was: 12h 10m)
> [Website revamp] Development of Contribution Guide page
> -------------------------------------------------------
>
> Key: BEAM-11424
> URL: https://issues.apache.org/jira/browse/BEAM-11424
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Agnieszka Sell
> Assignee: Jakub Sadowski
> Priority: P2
> Labels: website-revamp-2020, website-revamp-sprint-9
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
