[
https://issues.apache.org/jira/browse/BEAM-11700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17279805#comment-17279805
]
Yifan Mai commented on BEAM-11700:
----------------------------------
I'm happy to send a new PR to do this, but do we have an agreement on what the
state of things should be? My opinion is that the current state is fine because
it's similar to the state at 2.26 where the all optimization was allowed:
https://github.com/apache/beam/blob/0df7a8ea5dbc4f084e4b3b571f87253d180c07df/sdks/python/apache_beam/runners/portability/portable_runner.py
> Optimizations skipped in PortableRunner when pre_optimize is 'default' or
> 'all'
> -------------------------------------------------------------------------------
>
> Key: BEAM-11700
> URL: https://issues.apache.org/jira/browse/BEAM-11700
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Yifan Mai
> Assignee: Robert Bradshaw
> Priority: P2
> Fix For: 2.28.0
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> An indentation error in portable_runner.py is causing optimizations to not
> run when pre_optimize is set to default or all. This was broken by
> [#13573|https://github.com/apache/beam/pull/13573].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
