[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=549092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549092
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/21 14:32
Start Date: 06/Feb/21 14:32
Worklog Time Spent: 10m
Work Description: shehzaadn-vd edited a comment on pull request #13791:
URL: https://github.com/apache/beam/pull/13791#issuecomment-774484815
@ibzib i've brought back the compile lines and paired them with
permitUnusedDeclared. However, some of those permitUnusedDeclared lines seem to
cause this error:
```
Could not determine the dependencies of task
':sdks:java:io:google-cloud-platform:analyzeClassesDependencies'.
> Could not resolve all dependencies for configuration
':sdks:java:io:google-cloud-platform:permitUnusedDeclared'.
> Could not find io.grpc:grpc-alts:.
Required by:
project :sdks:java:io:google-cloud-platform
> Could not find io.grpc:grpc-core:.
Required by:
project :sdks:java:io:google-cloud-platform
> Could not find io.grpc:grpc-grpclb:.
Required by:
project :sdks:java:io:google-cloud-platform
> Could not find io.grpc:grpc-netty-shaded:.
Required by:
project :sdks:java:io:google-cloud-platform
> Could not find
com.google.api.grpc:proto-google-cloud-bigquerystorage-v1beta1:.
Required by:
project :sdks:java:io:google-cloud-platform
> Could not find
com.google.api.grpc:proto-google-cloud-spanner-admin-database-v1:.
Required by:
project :sdks:java:io:google-cloud-platform
```
My guess is permitUnusedDeclared doesn't play well with a library variable
where the version is set by the BOM
e.g. permitUnusedDeclared
library.java.proto_google_cloud_bigquery_storage_v1beta1
Any pointers on how to express such dependencies as permitUnusedDeclared -
hardcoding the version seems ugly...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 549092)
Time Spent: 109h (was: 108h 50m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 109h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
