[
https://issues.apache.org/jira/browse/BEAM-4164?focusedWorklogId=195540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-195540
]
ASF GitHub Bot logged work on BEAM-4164:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/19 08:55
Start Date: 07/Feb/19 08:55
Worklog Time Spent: 10m
Work Description: echauchot commented on issue #7751: [BEAM-4164]
[BEAM-6591] Refactor, improve and fix CassandraIO
URL: https://github.com/apache/beam/pull/7751#issuecomment-461335605
@kennknowles actually 2 bugs were fixed, you're talking about #2 right ? :
1- production code bug: split fix ticket BEAM-6591 commit 940db1b
2- test code bug: testDelete fix commit e90d66c
Both cannot be seen without the whole refactoring (basically all the commits
of this PR). on current master testDelete passes but it tests nothing because
it tests against a mock.
I'm not sure it is mandatory to fix all these things for the release but now
that we cut a RC3, we can do that.
Do you want me to cherry-pick all of them to the release branch ? Shall we
wait for the review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 195540)
Time Spent: 1h 10m (was: 1h)
> Make unit tests of CassandraIO use embeded server
> -------------------------------------------------
>
> Key: BEAM-4164
> URL: https://issues.apache.org/jira/browse/BEAM-4164
> Project: Beam
> Issue Type: Test
> Components: io-java-cassandra
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Labels: triaged
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The UT currently use a mock of the cassandra server. It would be good to do
> the tests using embeded Cassandra instance to be as close as possible from a
> real Cassandra server in the UT. Why not the one from cassandra-unit
> ([https://mvnrepository.com/artifact/org.cassandraunit/cassandra-unit/3.3.0.2])
> ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
