[
https://issues.apache.org/jira/browse/BEAM-11772?focusedWorklogId=550421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550421
]
ASF GitHub Bot logged work on BEAM-11772:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/21 21:16
Start Date: 09/Feb/21 21:16
Worklog Time Spent: 10m
Work Description: nehsyc commented on a change in pull request #13859:
URL: https://github.com/apache/beam/pull/13859#discussion_r573245433
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/FakeDatasetService.java
##########
@@ -62,8 +63,12 @@
Map<String, List<String>> insertErrors = Maps.newHashMap();
+ // The counter for the number of insertions performed.
+ static AtomicInteger insertCount;
Review comment:
It seems that the instance can be reconstructed for multiple times. If
not using a static variable, the counter will be zero at the verification time.
There is explanation for the static table map above:
...each ParDo will get a separate instance of FakeDatasetServices...
https://github.com/apache/beam/blob/595c25263638b3d5624875e46b69a442cedb09a7/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/testing/FakeDatasetService.java#L59
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550421)
Time Spent: 40m (was: 0.5h)
> GCP BigQuery sink (file loads) uses runner determined sharding for unbounded
> data
> ---------------------------------------------------------------------------------
>
> Key: BEAM-11772
> URL: https://issues.apache.org/jira/browse/BEAM-11772
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Integrate BigQuery sink with shardable `GroupIntoBatches` (BEAM-10475) to
> allow runner determined dynamic sharding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
