[
https://issues.apache.org/jira/browse/BEAM-11780?focusedWorklogId=550532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550532
]
ASF GitHub Bot logged work on BEAM-11780:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 02:06
Start Date: 10/Feb/21 02:06
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #13933:
URL: https://github.com/apache/beam/pull/13933#issuecomment-776383961
> > I think if they are solely dependencies for google-cloud-build they
won't be needed anymore? Do we need some special handling?
>
> Thanks. I thought originally that this PR checks in the google-cloud-build
code. Looks like you generated client code with apitools. google-apitools is
deprecated, and we were actually trying to move away from depending on
google-apitools and use official google-cloud-python libraries. This may be a
step in the opposite direction. cc: @aaltay - do you have any opinion here?
Perhaps we should look into addressing the difficulty of managing the
third_party deps for internal testing instead.
> do you have any opinion here?
This is just an **opinion**: It would be better to avoid generated clients.
They do end up causing more issues than regular dependencies, they are hard to
upgrade, usually stale, and apitools has been deprecated for a long time. I am
fine if we want to do this in there interim and unblock some testing, but a
much better solution would be to make this a proper dependency. I do not know
the specific issues but this is only one of many dependencies and I assume we
will have ways to address the issues with using a dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 550532)
Time Spent: 2h 10m (was: 2h)
> Use vendor cloud build client library so that cloudbuild-python dependency
> can be removed
> -----------------------------------------------------------------------------------------
>
> Key: BEAM-11780
> URL: https://issues.apache.org/jira/browse/BEAM-11780
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow, sdk-py-core
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This will make dataflow internal testing with prebuild sdk container workflow
> much easier.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
