[
https://issues.apache.org/jira/browse/BEAM-11520?focusedWorklogId=551543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-551543
]
ASF GitHub Bot logged work on BEAM-11520:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/21 21:59
Start Date: 11/Feb/21 21:59
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#13607:
URL: https://github.com/apache/beam/pull/13607#discussion_r574116539
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -114,10 +117,48 @@ def get_sdk_package_name():
Returns the PyPI package name to be staged."""
return names.BEAM_PACKAGE_NAME
+ @staticmethod
+ def _create_file_stage_to_artifact(local_path, staged_name):
+ return beam_runner_api_pb2.ArtifactInformation(
+ type_urn=common_urns.artifact_types.FILE.urn,
+ type_payload=beam_runner_api_pb2.ArtifactFilePayload(
+ path=local_path).SerializeToString(),
+ role_urn=common_urns.artifact_roles.STAGING_TO.urn,
+ role_payload=beam_runner_api_pb2.ArtifactStagingToRolePayload(
+ staged_name=staged_name).SerializeToString())
+
+ @staticmethod
+ def _create_file_pip_requirements_artifact(local_path):
+ return beam_runner_api_pb2.ArtifactInformation(
+ type_urn=common_urns.artifact_types.FILE.urn,
+ type_payload=beam_runner_api_pb2.ArtifactFilePayload(
+ path=local_path).SerializeToString(),
+ role_urn=common_urns.artifact_roles.PIP_REQUIREMENTS_FILE.urn)
+
+ @staticmethod
+ def extract_staging_tuple_iter(
+ artifacts: List[beam_runner_api_pb2.ArtifactInformation]):
+ for artifact in artifacts:
+ if artifact.type_urn == common_urns.artifact_types.FILE.urn:
Review comment:
Also fail for unknown type URNs ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 551543)
Time Spent: 5h 20m (was: 5h 10m)
> Stage extra PyPI dependencies with generated requirements
> ---------------------------------------------------------
>
> Key: BEAM-11520
> URL: https://issues.apache.org/jira/browse/BEAM-11520
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, java-fn-execution
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Stage extra PyPI dependencies with generated requirements
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
