[
https://issues.apache.org/jira/browse/BEAM-11810?focusedWorklogId=552095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-552095
]
ASF GitHub Bot logged work on BEAM-11810:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Feb/21 01:31
Start Date: 13/Feb/21 01:31
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13985:
URL: https://github.com/apache/beam/pull/13985#issuecomment-778537129
# [Codecov](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=h1) Report
> Merging
[#13985](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=desc) (4ec1a8f)
into
[master](https://codecov.io/gh/apache/beam/commit/4c81134dd9206fd6cb9060a9b973fc111b8fbd64?el=desc)
(4c81134) will **increase** coverage by `0.19%`.
> The diff coverage is `92.37%`.
[](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13985 +/- ##
==========================================
+ Coverage 82.77% 82.96% +0.19%
==========================================
Files 466 470 +4
Lines 57562 58455 +893
==========================================
+ Hits 47647 48499 +852
- Misses 9915 9956 +41
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/transforms/trigger.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy90cmlnZ2VyLnB5)
| `88.34% <75.00%> (-0.02%)` | :arrow_down: |
|
[...nners/portability/fn\_api\_runner/trigger\_manager.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyaWdnZXJfbWFuYWdlci5weQ==)
| `92.92% <92.92%> (ø)` | |
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `94.60% <100.00%> (ø)` | |
|
[...\_beam/runners/portability/sdk\_container\_builder.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zZGtfY29udGFpbmVyX2J1aWxkZXIucHk=)
| `40.00% <0.00%> (-3.28%)` | :arrow_down: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `86.45% <0.00%> (-1.05%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `91.07% <0.00%> (-0.90%)` | :arrow_down: |
|
[...ache\_beam/runners/portability/local\_job\_service.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9sb2NhbF9qb2Jfc2VydmljZS5weQ==)
| `80.53% <0.00%> (-0.64%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `89.54% <0.00%> (-0.32%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/expressions.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2V4cHJlc3Npb25zLnB5)
| `91.02% <0.00%> (-0.14%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/schemas.py](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3NjaGVtYXMucHk=)
| `96.87% <0.00%> (-0.12%)` | :arrow_down: |
| ... and [33
more](https://codecov.io/gh/apache/beam/pull/13985/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=footer). Last
update
[7c4a21a...4ec1a8f](https://codecov.io/gh/apache/beam/pull/13985?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 552095)
Time Spent: 40m (was: 0.5h)
> A trigger manager for the FnApiRunner
> -------------------------------------
>
> Key: BEAM-11810
> URL: https://issues.apache.org/jira/browse/BEAM-11810
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The existing trigger driver for the DirectRunner breaks the SDK-runner
> barrier. We need to implement a new trigger manager that runs on the SDK-side.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
