[
https://issues.apache.org/jira/browse/BEAM-4102?focusedWorklogId=196024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196024
]
ASF GitHub Bot logged work on BEAM-4102:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/19 23:51
Start Date: 07/Feb/19 23:51
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7781:
[BEAM-4102] use plugins DSL instead of manual classpath
URL: https://github.com/apache/beam/pull/7781#discussion_r254912783
##########
File path: buildSrc/build.gradle
##########
@@ -16,23 +16,41 @@
* limitations under the License.
*/
-// Define the set of repositories and dependencies required to
-// fetch and enable plugins.
-buildscript { dependencies { classpath
"com.diffplug.spotless:spotless-plugin-gradle:3.17.0" } }
-
// Plugins for configuring _this build_ of the module
-plugins { id 'groovy' }
-
-apply plugin: "com.diffplug.gradle.spotless"
+plugins {
+ id 'java-gradle-plugin'
+ id 'groovy'
+ id "com.diffplug.gradle.spotless" version "3.17.0"
+}
-// Dependencies on other plugins used when this plugin
-// is invoked
-repositories { jcenter() }
+// Define the set of repositories required to fetch and enable plugins.
+repositories {
+ jcenter()
+ maven { url "https://plugins.gradle.org/m2/"; }
+ maven { url "http://repo.spring.io/plugins-release"; }
+}
+// Dependencies on other plugins used when this plugin is invoked
dependencies {
compile gradleApi()
compile localGroovy()
compile 'com.github.jengelman.gradle.plugins:shadow:4.0.3'
+
+ runtime "net.ltgt.gradle:gradle-apt-plugin:0.20"
// Enable a Java annotation processor
Review comment:
Wow, this is much better to have these dependencies adjacent to the code
that needs them. Great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196024)
Time Spent: 0.5h (was: 20m)
> Use plugins DSL instead of manual classpath
> -------------------------------------------
>
> Key: BEAM-4102
> URL: https://issues.apache.org/jira/browse/BEAM-4102
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It looks like since Gradle 2.1 we can use a plugins { ... } block instead of
> how we have plugins manually set up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
