[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=553281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553281
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 00:41
Start Date: 17/Feb/21 00:41
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13830:
URL: https://github.com/apache/beam/pull/13830#discussion_r577238687
##########
File path: sdks/java/extensions/sql/zetasql/build.gradle
##########
@@ -31,23 +32,29 @@ def zetasql_version = "2020.10.1"
dependencies {
compile enforcedPlatform(library.java.google_cloud_platform_libraries_bom)
- compile project(":sdks:java:core")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
compile project(":sdks:java:extensions:sql")
+ compile project(":sdks:java:extensions:sql:udf")
compile library.java.vendored_calcite_1_20_0
compile library.java.guava
compile library.java.grpc_api
+ compile library.java.joda_time
compile library.java.protobuf_java
compile library.java.protobuf_java_util
- compile "com.google.api.grpc:proto-google-common-protos:1.12.0" //
Interfaces with ZetaSQL use this
- compile "com.google.api.grpc:grpc-google-common-protos:1.12.0" // Interfaces
with ZetaSQL use this
- compile "com.google.zetasql:zetasql-jni-channel:$zetasql_version"
+ permitUnusedDeclared library.java.protobuf_java_util
+ compile library.java.slf4j_api
+ compile library.java.vendored_guava_26_0_jre
+ compile library.java.proto_google_common_protos // Interfaces with ZetaSQL
use this
+ permitUnusedDeclared "com.google.api.grpc:proto-google-common-protos:2.0.1"
// BEAM-11761
Review comment:
> Regarding your comment about this being added twice, they are actually
two different dependencies:
Oops, you're right. I didn't read carefully.
> I couldn't get permitUnusedDeclared to work with the library.java variable
when the version is coming from the bom. It seems permitUnusedDeclared sees a
blank version and fails.
We should be able to work around this by resolving the bom versions before
running analyzeClassesDependencies. But I'm not sure exactly how. Filed
BEAM-11823 to track.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553281)
Time Spent: 122h 20m (was: 122h 10m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 122h 20m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
