[
https://issues.apache.org/jira/browse/BEAM-11805?focusedWorklogId=553319&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553319
]
ASF GitHub Bot logged work on BEAM-11805:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 01:55
Start Date: 17/Feb/21 01:55
Worklog Time Spent: 10m
Work Description: allenpradeep commented on a change in pull request
#13990:
URL: https://github.com/apache/beam/pull/13990#discussion_r577270669
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
##########
@@ -150,14 +189,34 @@ private static SpannerAccessor
createAndConnect(SpannerConfig spannerConfig) {
ValueProvider<String> host = spannerConfig.getHost();
if (host != null) {
builder.setHost(host.get());
+ instantiatingGrpcChannelProvider.setEndpoint(getEndpoint(host.get()));
}
ValueProvider<String> emulatorHost = spannerConfig.getEmulatorHost();
if (emulatorHost != null) {
builder.setEmulatorHost(emulatorHost.get());
builder.setCredentials(NoCredentials.getInstance());
+ } else {
Review comment:
This is to enable a fail fast if the emulator is not running, but the
user has set the emulator host environment variable.
As per
[function-checkEmulatorConnection](https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L497-L539)
[line
502](https://github.com/googleapis/java-spanner/blob/master/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java#L502),
the fail fast link works only if the channelprovider is set to null. This
workaround only sets the channel provider only when we are not going to connect
to emulator.
cc @thiagotnunes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553319)
Time Spent: 7h 50m (was: 7h 40m)
> SpannerReadIT broken in PostCommit_Java
> ---------------------------------------
>
> Key: BEAM-11805
> URL: https://issues.apache.org/jira/browse/BEAM-11805
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Brian Hulette
> Assignee: Allen Pradeep Xavier
> Priority: P1
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> SpannerReadIT started failing after https://github.com/apache/beam/pull/13765
> went in:
> https://ci-beam.apache.org/job/beam_PostCommit_Java/7195/
> Example log:
> {code}
> java.lang.RuntimeException: java.lang.RuntimeException:
> org.apache.beam.sdk.util.UserCodeException:
> java.lang.IllegalArgumentException: Multiple entries with same key:
> user-agent=Apache_Beam_Java/2.29.0-SNAPSHOT and user-agent=spanner-java/3.2.1
> at
> org.apache.beam.runners.dataflow.worker.IntrinsicMapTaskExecutorFactory$1.typedApply(IntrinsicMapTaskExecutorFactory.java:197)
> at
> org.apache.beam.runners.dataflow.worker.IntrinsicMapTaskExecutorFactory$1.typedApply(IntrinsicMapTaskExecutorFactory.java:168)
> at
> org.apache.beam.runners.dataflow.worker.graph.Networks$TypeSafeNodeFunction.apply(Networks.java:66)
> at
> org.apache.beam.runners.dataflow.worker.graph.Networks$TypeSafeNodeFunction.apply(Networks.java:53)
> at
> org.apache.beam.runners.dataflow.worker.graph.Networks.replaceDirectedNetworkNodes(Networks.java:90)
> at
> org.apache.beam.runners.dataflow.worker.IntrinsicMapTaskExecutorFactory.create(IntrinsicMapTaskExecutorFactory.java:128)
> at
> org.apache.beam.runners.dataflow.worker.BatchDataflowWorker.doWork(BatchDataflowWorker.java:361)
> at
> org.apache.beam.runners.dataflow.worker.BatchDataflowWorker.getAndPerformWork(BatchDataflowWorker.java:314)
> at
> org.apache.beam.runners.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.doWork(DataflowBatchWorkerHarness.java:140)
> at
> org.apache.beam.runners.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.call(DataflowBatchWorkerHarness.java:120)
> at
> org.apache.beam.runners.dataflow.worker.DataflowBatchWorkerHarness$WorkerThread.call(DataflowBatchWorkerHarness.java:107)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.beam.sdk.util.UserCodeException:
> java.lang.IllegalArgumentException: Multiple entries with same key:
> user-agent=Apache_Beam_Java/2.29.0-SNAPSHOT and user-agent=spanner-java/3.2.1
> at
> org.apache.beam.sdk.util.UserCodeException.wrap(UserCodeException.java:39)
> at
> org.apache.beam.sdk.io.gcp.spanner.CreateTransactionFn$DoFnInvoker.invokeSetup(Unknown
> Source)
> at
> org.apache.beam.runners.dataflow.worker.DoFnInstanceManagers$ConcurrentQueueInstanceManager.deserializeCopy(DoFnInstanceManagers.java:83)
> at
> org.apache.beam.runners.dataflow.worker.DoFnInstanceManagers$ConcurrentQueueInstanceManager.peek(DoFnInstanceManagers.java:65)
> at
> org.apache.beam.runners.dataflow.worker.UserParDoFnFactory.create(UserParDoFnFactory.java:99)
> at
> org.apache.beam.runners.dataflow.worker.DefaultParDoFnFactory.create(DefaultParDoFnFactory.java:75)
> at
> org.apache.beam.runners.dataflow.worker.IntrinsicMapTaskExecutorFactory.createParDoOperation(IntrinsicMapTaskExecutorFactory.java:267)
> at
> org.apache.beam.runners.dataflow.worker.IntrinsicMapTaskExecutorFactory.access$000(IntrinsicMapTaskExecutorFactory.java:89)
> at
> org.apache.beam.runners.dataflow.worker.IntrinsicMapTaskExecutorFactory$1.typedApply(IntrinsicMapTaskExecutorFactory.java:186)
> ... 14 more
> Caused by: java.lang.IllegalArgumentException: Multiple entries with same
> key: user-agent=Apache_Beam_Java/2.29.0-SNAPSHOT and
> user-agent=spanner-java/3.2.1
> at
> com.google.common.collect.ImmutableMap.conflictException(ImmutableMap.java:215)
> at
> com.google.common.collect.ImmutableMap.checkNoConflict(ImmutableMap.java:209)
> at
> com.google.common.collect.RegularImmutableMap.checkNoConflictInKeyBucket(RegularImmutableMap.java:147)
> at
> com.google.common.collect.RegularImmutableMap.fromEntryArray(RegularImmutableMap.java:110)
> at
> com.google.common.collect.ImmutableMap$Builder.build(ImmutableMap.java:393)
> at
> com.google.cloud.spanner.spi.v1.GapicSpannerRpc.<init>(GapicSpannerRpc.java:320)
> at
> com.google.cloud.spanner.SpannerOptions$DefaultSpannerRpcFactory.create(SpannerOptions.java:467)
> at
> com.google.cloud.spanner.SpannerOptions$DefaultSpannerRpcFactory.create(SpannerOptions.java:462)
> at com.google.cloud.ServiceOptions.getRpc(ServiceOptions.java:561)
> at
> com.google.cloud.spanner.SpannerOptions.getSpannerRpcV1(SpannerOptions.java:1169)
> at com.google.cloud.spanner.SpannerImpl.<init>(SpannerImpl.java:134)
> at
> com.google.cloud.spanner.SpannerOptions$DefaultSpannerFactory.create(SpannerOptions.java:457)
> at
> com.google.cloud.spanner.SpannerOptions$DefaultSpannerFactory.create(SpannerOptions.java:452)
> at com.google.cloud.ServiceOptions.getService(ServiceOptions.java:541)
> at
> org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor.createAndConnect(SpannerAccessor.java:163)
> at
> org.apache.beam.sdk.io.gcp.spanner.SpannerAccessor.getOrCreate(SpannerAccessor.java:98)
> at
> org.apache.beam.sdk.io.gcp.spanner.CreateTransactionFn.setup(CreateTransactionFn.java:39)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
