[
https://issues.apache.org/jira/browse/BEAM-11812?focusedWorklogId=553395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553395
]
ASF GitHub Bot logged work on BEAM-11812:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 05:39
Start Date: 17/Feb/21 05:39
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #13998:
URL: https://github.com/apache/beam/pull/13998#issuecomment-780313629
See #14001 which might be related. CC @robertwb here too.
In portability, I wonder if `InvalidWindows` is obsolete. The only reason
for it was to crash in this case:
1. User sets keys and chooses session windowing
3. User groups/combines by session
4. User maps the outputs to some new keys
5. User groups again
In the original model, the second grouping would do merging again, and
probably be something random that they did not intend. Or anyhow that is how I
remember the reasoning.
Now I think `MergeStatus.ALREADY_MERGED` would allow better behavior. In the
second group by key the windows would be treated as non-merging.
Was there any discussion of `MergeStatus` that I may have missed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553395)
Time Spent: 1h (was: 50m)
> PostCommit Java VR ULR Failing
> ------------------------------
>
> Key: BEAM-11812
> URL: https://issues.apache.org/jira/browse/BEAM-11812
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Brian Hulette
> Assignee: Yichi Zhang
> Priority: P1
> Labels: currently-failing
> Time Spent: 1h
> Remaining Estimate: 0h
>
> First failure:
> https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/534/
> Failing
> org.apache.beam.sdk.transforms.ReshuffleTest.testReshuffleAfterSessionsAndGroupByKey
> {code}
> java.lang.RuntimeException: The Runner experienced the following error during
> execution:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/local_job_service.py",
> line 275, in _run_job
> result = fn_runner.FnApiRunner(
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
> line 193, in run_via_runner_api
> return self.run_stages(stage_context, stages)
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
> line 356, in run_stages
> stage_results = self._run_stage(
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
> line 547, in _run_stage
> last_result, deferred_inputs, fired_timers = self._run_bundle(
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
> line 593, in _run_bundle
> result, splits = bundle_manager.process_bundle(
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
> line 886, in process_bundle
> self._send_input_to_worker(process_bundle_id, transform_id, elements)
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py",
> line 762, in _send_input_to_worker
> for byte_stream in byte_streams:
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py",
> line 254, in __iter__
> return itertools.chain(*self.partition(1))
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py",
> line 240, in partition
> for wkvs in windowed_key_values(key, windowed_values):
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/transforms/trigger.py",
> line 1126, in process_entire_key
> for wvalue in self.process_elements(state,
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/transforms/trigger.py",
> line 1308, in process_elements
> self.window_fn.merge(TriggerMergeContext(all_windows))
> File
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_ValidatesRunner_ULR/src/sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py",
> line 423, in merge
> raise RuntimeError(result.error)
> RuntimeError: java.lang.UnsupportedOperationException
> at
> org.apache.beam.sdk.transforms.windowing.InvalidWindows.mergeWindows(InvalidWindows.java:55)
> at
> org.apache.beam.fn.harness.WindowMergingFnRunner$MergingViaWindowFnRunner.mergeWindows(WindowMergingFnRunner.java:153)
> at
> org.apache.beam.fn.harness.MapFnRunners$CompressedValueOnlyMapperFactory.lambda$create$0(MapFnRunners.java:187)
> at
> org.apache.beam.fn.harness.data.PCollectionConsumerRegistry$MetricTrackingFnDataReceiver.accept(PCollectionConsumerRegistry.java:222)
> at
> org.apache.beam.fn.harness.data.PCollectionConsumerRegistry$MetricTrackingFnDataReceiver.accept(PCollectionConsumerRegistry.java:185)
> at
> org.apache.beam.fn.harness.BeamFnDataReadRunner.forwardElementToConsumer(BeamFnDataReadRunner.java:220)
> at
> org.apache.beam.sdk.fn.data.DecodingFnDataReceiver.accept(DecodingFnDataReceiver.java:43)
> at
> org.apache.beam.sdk.fn.data.DecodingFnDataReceiver.accept(DecodingFnDataReceiver.java:25)
> at
> org.apache.beam.fn.harness.data.QueueingBeamFnDataClient.drainAndBlock(QueueingBeamFnDataClient.java:111)
> at
> org.apache.beam.fn.harness.control.ProcessBundleHandler.processBundle(ProcessBundleHandler.java:308)
> at
> org.apache.beam.fn.harness.control.BeamFnControlClient.delegateOnInstructionRequestType(BeamFnControlClient.java:173)
> at
> org.apache.beam.fn.harness.control.BeamFnControlClient.lambda$processInstructionRequests$0(BeamFnControlClient.java:157)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
