[
https://issues.apache.org/jira/browse/BEAM-11778?focusedWorklogId=553401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553401
]
ASF GitHub Bot logged work on BEAM-11778:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 05:56
Start Date: 17/Feb/21 05:56
Worklog Time Spent: 10m
Work Description: amaliujia edited a comment on pull request #13934:
URL: https://github.com/apache/beam/pull/13934#issuecomment-780320143
Is there any explantation (one pager or JIRA) to explain the intention of
this refactoring? Especially what is the follow up steps after this PR? (this
solely refactoring does not look very useful)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 553401)
Time Spent: 1h 20m (was: 1h 10m)
> Create an extension of SimpleCatalog.
> -------------------------------------
>
> Key: BEAM-11778
> URL: https://issues.apache.org/jira/browse/BEAM-11778
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There's currently a lot of catalog-related logic in
> [SqlAnalyzer|https://github.com/apache/beam/blob/f0bd06603ecfc5466adfb69385323aee36bfa2d6/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java#L256].
> Creating an extension of SimpleCatalog to contain that logic will let us
> achieve cleaner abstractions, and ensure the catalog stays in sync with its
> backing Schema.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)