[
https://issues.apache.org/jira/browse/BEAM-11589?focusedWorklogId=554035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554035
]
ASF GitHub Bot logged work on BEAM-11589:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/21 02:23
Start Date: 18/Feb/21 02:23
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14002:
URL: https://github.com/apache/beam/pull/14002#discussion_r578080348
##########
File path: vendor/bytebuddy-1_10_8/build.gradle.kts
##########
@@ -16,22 +16,25 @@
* limitations under the License.
*/
-plugins { id 'org.apache.beam.vendor-java' }
+plugins { id("org.apache.beam.vendor-java") }
description = "Apache Beam :: Vendored Dependencies :: ByteBuddy :: 1.10.8"
group = "org.apache.beam"
version = "0.1"
+val vendorJava = project.extensions.extraProperties.get("vendorJava") as
groovy.lang.Closure<*>
vendorJava(
- dependencies: ["net.bytebuddy:byte-buddy:1.10.8"],
- relocations: [
- "net.bytebuddy": "org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"
- ],
- exclusions: [
+ mapOf(
+
+ "dependencies" to listOf("net.bytebuddy:byte-buddy:1.10.8"),
+ "relocations" to mapOf(
+ "net.bytebuddy" to
"org.apache.beam.vendor.bytebuddy.v1_10_8.net.bytebuddy"),
+ "exclusions" to listOf(
"**/module-info.class"
- ],
- groupId: group,
- artifactId: "beam-vendor-bytebuddy-1_10_8",
- version: version
+ ),
+ "groupId" to group,
+ "artifactId" to "beam-vendor-bytebuddy-1_10_8",
+ "version" to version
+)
Review comment:
nit: the formatting here is a little weird.
It might be worth looking into auto-formatting these files with the spotless
plugin (i.e. so that `./gradlew spotlessApply` will format them)
I think it should be like
```
vendorJava(
mapOf(
"dependencies" to ..
....
)
)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 554035)
Time Spent: 15.5h (was: 15h 20m)
> Migrate Gradle scripts from Groovy to Kotlin DSL.
> -------------------------------------------------
>
> Key: BEAM-11589
> URL: https://issues.apache.org/jira/browse/BEAM-11589
> Project: Beam
> Issue Type: Wish
> Components: build-system
> Reporter: Kyle Weaver
> Assignee: Ramazan Yapparov
> Priority: P2
> Time Spent: 15.5h
> Remaining Estimate: 0h
>
> Our current Gradle build scripts/configs use the traditional Groovy DSL.
> Gradle supports a newer Kotlin DSL, and Kotlin is (in my biased opinion) a
> better language than Groovy.
> https://docs.gradle.org/nightly/userguide/migrating_from_groovy_to_kotlin_dsl.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
