[
https://issues.apache.org/jira/browse/BEAM-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286613#comment-17286613
]
Beam JIRA Bot commented on BEAM-9179:
-------------------------------------
This issue was marked "stale-P2" and has not received a public comment in 14
days. It is now automatically moved to P3. If you are still affected by it, you
can comment and move it back to P2.
> Refactor Beam ZetaSQL type translation code
> -------------------------------------------
>
> Key: BEAM-9179
> URL: https://issues.apache.org/jira/browse/BEAM-9179
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql-zetasql
> Reporter: Robin Qiu
> Priority: P3
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Currently, how types work in Beam ZetaSQL is very confusing: code that does
> type conversion between Calcite/Beam/ZetaSQL type systems are everywhere and
> is likely to be not consistent. In addition, the recent migration to
> BeamZetaSqlCalcRel makes the situation even worse: it adds another layer for
> type conversion and makes a lot of code (for making ZetaSQL functions
> manually) obsolete. This makes debugging and supporting new features very
> hard. A few examples:
> * Support new ZetaSQL types (e.g. DATE/TIME/DATETIME)
> * Fix the long-standing precision & timezone issue of TIMESTMAP type
> * Support BeamSQL query parameters
> Therefore, I propose we work on the following items to make the story of Beam
> ZetaSQL type clearer:
> * Define a clear mapping between Calcite/Beam/ZetaSQL types and values
> * Refactor the codebase to move all type conversion code to a single source
> of truth
> * Add thorough testing for it
> * Remove obsolete code that is added to make functions work before
> BeamZetaSqlCalcRel
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
