[
https://issues.apache.org/jira/browse/BEAM-11747?focusedWorklogId=554502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554502
]
ASF GitHub Bot logged work on BEAM-11747:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/21 22:23
Start Date: 18/Feb/21 22:23
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #14015:
URL: https://github.com/apache/beam/pull/14015#discussion_r578786490
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLQueryPlanner.java
##########
@@ -160,8 +165,10 @@ static boolean hasOnlyJavaUdfInProjects(RelOptRuleCall x) {
SqlUserDefinedFunction udf = (SqlUserDefinedFunction) call.op;
if (udf.function instanceof ZetaSqlScalarFunctionImpl) {
ZetaSqlScalarFunctionImpl scalarFunction =
(ZetaSqlScalarFunctionImpl) udf.function;
- if (!scalarFunction.functionGroup.equals(
+ if (scalarFunction.functionGroup.equals(
SqlAnalyzer.USER_DEFINED_JAVA_SCALAR_FUNCTIONS)) {
+ udfs.add(i);
+ } else {
Review comment:
Only RexCall has getOperands. I was under the impression that these
operands are garenteed to be prior entries returned in ExprList. It will be a
little while before I have time to verify. If that is not the case, it is easy
to transform the ExprList into that form. That will need to be true for this to
be correct and for calc splitting to be easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 554502)
Time Spent: 11h (was: 10h 50m)
> Reject the mixed Java UDF and ZetaSQL builtin operators cases
> --------------------------------------------------------------
>
> Key: BEAM-11747
> URL: https://issues.apache.org/jira/browse/BEAM-11747
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql-zetasql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: P2
> Time Spent: 11h
> Remaining Estimate: 0h
>
> Before we have Calc splitting implemented, we can reject the mixed Java UDF
> and ZetaSQL builtin operators cases to maintain the correctness of a query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
