[
https://issues.apache.org/jira/browse/BEAM-11833?focusedWorklogId=555963&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-555963
]
ASF GitHub Bot logged work on BEAM-11833:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/21 18:59
Start Date: 22/Feb/21 18:59
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #14013:
URL: https://github.com/apache/beam/pull/14013#issuecomment-783598412
> > I'm afraid that setting watermark both before and after the tryClaim
loop is still not enough. For most cases, every time tryClaim is called and
there is one output record, the watermark should advance. If we only set
watermark outside of tryClaim loop, we will still hold back the watermark
somehow.
>
> Alright, that is true. I'd suggest we add watermark into the
`UnboundedSourceValue`, I'd prefer to avoid materializing the
`currentRestriction()` in the tryClaim loop. WDYT?
That sounds good to me. Would you like to make the change in this PR
together? Meanwhile I'll double check the implementation to ensure we don't
introduce additional bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 555963)
Time Spent: 3h (was: 2h 50m)
> UnboundedSourceAsSDFRestrictionTracker reports incorrect watermark after
> failed claim
> -------------------------------------------------------------------------------------
>
> Key: BEAM-11833
> URL: https://issues.apache.org/jira/browse/BEAM-11833
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.28.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P1
> Time Spent: 3h
> Remaining Estimate: 0h
>
> After being split by call to {{trySplit}}, the watermark reported by
> {{UnboundedSourceAsSDFRestrictionTracker.currentRestriction().getWatermark()}}
> is BoundedWindow.TIMESTAMP_MAX_VALUE, which is incorrect.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
