[
https://issues.apache.org/jira/browse/BEAM-11408?focusedWorklogId=556516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556516
]
ASF GitHub Bot logged work on BEAM-11408:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 19:05
Start Date: 23/Feb/21 19:05
Worklog Time Spent: 10m
Work Description: nehsyc commented on a change in pull request #14033:
URL: https://github.com/apache/beam/pull/14033#discussion_r581311537
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1759,6 +1814,8 @@ def serialize(side_inputs):
'triggering_frequency': self.triggering_frequency,
'validate': self._validate,
'temp_file_format': self._temp_file_format,
+ 'ignore_insert_ids': self._ignore_insert_ids,
Review comment:
`ignore_insert_ids` was previously not added to runner api parameter.
Wondering if this is a bug as when we convert from the runner api the parameter
will be lost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556516)
Time Spent: 11h 20m (was: 11h 10m)
> GCP BigQuery sink (streaming inserts) uses runner determined sharding
> ---------------------------------------------------------------------
>
> Key: BEAM-11408
> URL: https://issues.apache.org/jira/browse/BEAM-11408
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Fix For: 2.28.0
>
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> Integrate BigQuery sink with shardable `GroupIntoBatches` (BEAM-10475) to
> allow runner determined dynamic sharding.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
