[
https://issues.apache.org/jira/browse/BEAM-11824?focusedWorklogId=556559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556559
]
ASF GitHub Bot logged work on BEAM-11824:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/21 21:20
Start Date: 23/Feb/21 21:20
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14001:
URL: https://github.com/apache/beam/pull/14001#discussion_r581395321
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/WindowingStrategyTranslation.java
##########
@@ -295,10 +299,17 @@ public static FunctionSpec toProto(WindowFn<?, ?>
windowFn, SdkComponents compon
.setAllowedLateness(windowingStrategy.getAllowedLateness().getMillis())
.setTrigger(TriggerTranslation.toProto(windowingStrategy.getTrigger()))
.setWindowFn(windowFnSpec)
-
.setAssignsToOneWindow(windowingStrategy.getWindowFn().assignsToOneWindow())
+ .setAssignsToOneWindow(windowFn.assignsToOneWindow())
+ .setMergeStatus(
+ windowFn instanceof InvalidWindows
+ ? (((InvalidWindows)
windowFn).getOriginalWindowFn().isNonMerging()
Review comment:
Per dev@ list discussion, I'm going to change this to not special-case
`InvalidWindows`. For now: if it is a merging WindowFn it says NEEDS_MERGE,
otherwise it doesn't.
Once I finish adjusting the SDKs to actually track ALREADY_MERGED bit, I
will adjust the translation too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556559)
Time Spent: 1.5h (was: 1h 20m)
> WindowingStrategyTranslation does not set merge status in proto
> ---------------------------------------------------------------
>
> Key: BEAM-11824
> URL: https://issues.apache.org/jira/browse/BEAM-11824
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: P1
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> For example, session windows do not result in {{MergeStatus.NEEDS_MERGE}}. So
> a runner that respects that bit (or doesn't special case sessions) will fail.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
