[ 
https://issues.apache.org/jira/browse/BEAM-11144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17289572#comment-17289572
 ] 

Sam Whittle commented on BEAM-11144:
------------------------------------

Yes, thanks!




> TriggerStateMachine.prefetchOnElement and other prefetch methods use 
> incorrect state for subtriggers
> ----------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-11144
>                 URL: https://issues.apache.org/jira/browse/BEAM-11144
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Sam Whittle
>            Assignee: Sam Whittle
>            Priority: P2
>             Fix For: 2.26.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> prefetchOnElement takes a single StateAccessor corresponding to the root 
> trigger.  It uses that state accessor to perform prefetches for the 
> subtrigger state. However that will use the root trigger namespace for the 
> tags in the subtriggers.  This makes prefetching ineffective, introducing 
> possibly an additional round-trip once the data is actually read.
> https://github.com/apache/beam/blob/68d6c8e6243b1d8f392840273f886276e2a8baff/runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachine.java#L296



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to