[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=556690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-556690
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/21 02:12
Start Date: 24/Feb/21 02:12
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #14047:
URL: https://github.com/apache/beam/pull/14047#discussion_r581565456
##########
File path: sdks/java/io/azure/build.gradle
##########
@@ -29,13 +30,19 @@ ext.summary = "IO library to read and write Azure services
from Beam."
repositories { jcenter() }
dependencies {
+ compile library.java.commons_io
+ permitUnusedDeclared library.java.commons_io
Review comment:
Link to the JIRA here.
##########
File path: sdks/java/io/azure/build.gradle
##########
@@ -29,13 +30,19 @@ ext.summary = "IO library to read and write Azure services
from Beam."
repositories { jcenter() }
dependencies {
+ compile library.java.commons_io
+ permitUnusedDeclared library.java.commons_io
+ compile library.java.slf4j_api
compile library.java.vendored_guava_26_0_jre
compile project(path: ":sdks:java:core", configuration: "shadow")
compile "com.azure:azure-storage-blob:12.8.0"
compile "com.azure:azure-identity:1.0.8"
compile "com.microsoft.azure:azure-storage:8.6.5"
- compile "commons-io:commons-io:2.6"
- compile library.java.slf4j_api
+ compile "com.azure:azure-core:1.6.0"
+ compile "com.azure:azure-storage-common:12.1.0"
Review comment:
azure-storage-common should have the same version as azure-storage-blob
(since azure-storage-common is currently a transitive dependency imported by
azure-storage-blob).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 556690)
Time Spent: 126h 50m (was: 126h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 126h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
