[
https://issues.apache.org/jira/browse/BEAM-5949?focusedWorklogId=557240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-557240
]
ASF GitHub Bot logged work on BEAM-5949:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/21 18:35
Start Date: 24/Feb/21 18:35
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #13887:
URL: https://github.com/apache/beam/pull/13887#issuecomment-785285326
I think we need to verify that Beam's cythonization is using Py3 semantic
before merging this or similar changes, otherwise the behavior in cythonized
codepath could change.
For example there are directives in some files:
https://github.com/apache/beam/blob/53560566c1482cd54a03641fe82089a7ead6bf79/sdks/python/apache_beam/coders/coder_impl.py#L18
but we may not have them in other file. I don't know if there is a way to
make it a default when we invoke Cython or build wheels for all files without
upgrading to Cython 3 when this becomes default. CC: @robertwb who may have
advice.
I'll have to park this change for a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 557240)
Time Spent: 2h 20m (was: 2h 10m)
> Remove __ne__ when Beam Python drops Python 2 support
> -----------------------------------------------------
>
> Key: BEAM-5949
> URL: https://issues.apache.org/jira/browse/BEAM-5949
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Charles Chen
> Priority: P3
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We should remove the instances of __ne__ added for Python 2 compatibility
> when Beam Python drops Python 2 support (see
> https://github.com/apache/beam/pull/6924).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
