[
https://issues.apache.org/jira/browse/BEAM-6602?focusedWorklogId=196473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196473
]
ASF GitHub Bot logged work on BEAM-6602:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/19 23:36
Start Date: 08/Feb/19 23:36
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7743:
[BEAM-6602] Preparatory PR for integrating schemas into BigQuery: Push TableRow
conversion to end of pipeline
URL: https://github.com/apache/beam/pull/7743#discussion_r255267502
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StreamingWriteTables.java
##########
@@ -43,59 +45,125 @@
* <p>This transform assumes that all destination tables already exist by the
time it sees a write
* for that table.
*/
-public class StreamingWriteTables
- extends PTransform<PCollection<KV<TableDestination, TableRow>>,
WriteResult> {
+public class StreamingWriteTables<ElementT>
+ extends PTransform<PCollection<KV<TableDestination, ElementT>>,
WriteResult> {
private BigQueryServices bigQueryServices;
private InsertRetryPolicy retryPolicy;
private boolean extendedErrorInfo;
private static final String FAILED_INSERTS_TAG_ID = "failedInserts";
private final boolean skipInvalidRows;
private final boolean ignoreUnknownValues;
+ private final Coder<ElementT> elementCoder;
+ private final SerializableFunction<ElementT, TableRow> toTableRow;
public StreamingWriteTables() {
- this(new BigQueryServicesImpl(), InsertRetryPolicy.alwaysRetry(), false,
false, false);
+ this(
+ new BigQueryServicesImpl(),
+ InsertRetryPolicy.alwaysRetry(),
+ false,
+ false,
Review comment:
Please add comments with variable names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196473)
Time Spent: 0.5h (was: 20m)
> Support schemas in BigQueryIO.Write
> -----------------------------------
>
> Key: BEAM-6602
> URL: https://issues.apache.org/jira/browse/BEAM-6602
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-gcp
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Labels: triaged
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
