[
https://issues.apache.org/jira/browse/BEAM-11740?focusedWorklogId=558108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558108
]
ASF GitHub Bot logged work on BEAM-11740:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/21 19:43
Start Date: 25/Feb/21 19:43
Worklog Time Spent: 10m
Work Description: kileys commented on a change in pull request #13924:
URL: https://github.com/apache/beam/pull/13924#discussion_r583115270
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/data/PCollectionConsumerRegistry.java
##########
@@ -210,8 +233,8 @@ public void accept(WindowedValue<T> input) throws Exception
{
try (Closeable close =
MetricsEnvironment.scopedMetricsContainer(this.unboundMetricContainer)) {
// Increment the counter for each window the element occurs in.
- this.counter.inc(input.getWindows().size());
-
+ this.elementCountCounter.inc(input.getWindows().size());
+ this.sampledByteSizeDistribution.tryUpdate(input.getValue(),
this.coder);
Review comment:
Since this is a mean value, don't we want to keep it the metric size of
1 window?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558108)
Time Spent: 1h 50m (was: 1h 40m)
> Add PCollection size estimate to Java SDK harness
> -------------------------------------------------
>
> Key: BEAM-11740
> URL: https://issues.apache.org/jira/browse/BEAM-11740
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness
> Reporter: Kiley Sok
> Assignee: Kiley Sok
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
