[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=558214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558214
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/21 21:43
Start Date: 25/Feb/21 21:43
Worklog Time Spent: 10m
Work Description: shehzaadn-vd commented on a change in pull request
#13791:
URL: https://github.com/apache/beam/pull/13791#discussion_r583222291
##########
File path: sdks/java/io/google-cloud-platform/build.gradle
##########
@@ -53,48 +58,78 @@ dependencies {
compile(library.java.google_cloud_core_grpc) {
exclude group: 'io.grpc', module: 'grpc-core' // Use Beam's version
}
+ permitUnusedDeclared library.java.google_cloud_core_grpc // BEAM-11761
compile library.java.google_cloud_datastore_v1_proto_client
compile library.java.google_cloud_pubsublite
// GCP PubSub client is used in TestPubSub
compile library.java.google_cloud_pubsub
compile library.java.google_cloud_spanner
+ compile library.java.google_code_gson
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.grpc_alts
+ permitUnusedDeclared library.java.grpc_alts // BEAM-11761
compile library.java.grpc_api
compile library.java.grpc_auth
compile library.java.grpc_core
+ permitUnusedDeclared library.java.grpc_core // BEAM-11761
compile library.java.grpc_context
+ permitUnusedDeclared library.java.grpc_context // BEAM-11761
compile library.java.grpc_grpclb
+ permitUnusedDeclared library.java.grpc_grpclb // BEAM-11761
compile library.java.grpc_netty
compile library.java.grpc_netty_shaded
+ permitUnusedDeclared library.java.grpc_netty_shaded // BEAM-11761
compile library.java.grpc_stub
+ permitUnusedDeclared library.java.grpc_stub // BEAM-11761
compile library.java.grpc_google_cloud_pubsub_v1
compile library.java.grpc_google_cloud_pubsublite_v1
+ permitUnusedDeclared library.java.grpc_google_cloud_pubsublite_v1 //
BEAM-11761
compile library.java.guava
+ compile library.java.hamcrest
+ compile library.java.http_client
compile library.java.hamcrest_core
+ permitUnusedDeclared library.java.hamcrest_core // BEAM-11761
+ compile library.java.http_core
+ compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
compile library.java.junit
compile library.java.netty_handler
compile library.java.netty_tcnative_boringssl_static
+ permitUnusedDeclared library.java.netty_tcnative_boringssl_static //
BEAM-11761
+ compile library.java.proto_google_cloud_bigquery_storage_v1
+ compile library.java.proto_google_cloud_bigquery_storage_v1beta1
Review comment:
Ah yes. Should have noticed that after I merged with master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558214)
Time Spent: 149.5h (was: 149h 20m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 149.5h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
