[
https://issues.apache.org/jira/browse/BEAM-11436?focusedWorklogId=558350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558350
]
ASF GitHub Bot logged work on BEAM-11436:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/21 02:11
Start Date: 26/Feb/21 02:11
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #14101:
URL: https://github.com/apache/beam/pull/14101#issuecomment-786360540
Note this doesn't remove the suppressions added in
https://github.com/apache/beam/pull/13191/commits/5675108933de6eb601ca2e4f21870d2ababe0ec7.
I thought I might be able to back it out with `git revert` restricted to just
`test` directories, but for some reason git flags trivial merge conflicts for
seemingly any test file that's had a change made to it in the meantime, even
though the changes are rarely on the same lines.
Maybe I can come up with a better approach in the morning.. (generate a
patch and reverse it?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558350)
Time Spent: 20m (was: 10m)
> Nullness checks are excessive for test classes
> ----------------------------------------------
>
> Key: BEAM-11436
> URL: https://issues.apache.org/jira/browse/BEAM-11436
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Labels: stale-assigned
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We don't have checkerframework nullness annotations for JUnit, which often
> leads to difficult nullness errors. The most onerous is that assertNotNull
> requires the argument to be NonNull already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
