[
https://issues.apache.org/jira/browse/BEAM-11436?focusedWorklogId=558634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558634
]
ASF GitHub Bot logged work on BEAM-11436:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/21 17:15
Start Date: 26/Feb/21 17:15
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on pull request #14101:
URL: https://github.com/apache/beam/pull/14101#issuecomment-786777942
Ok, turns out the conflicts weren't trivial, because additional suppression
were added in the meantime. I found the following worked:
```
# Remove any lines with just nullness TODO(BEAM-10402)
sed -Ei
'/^\s*"nullness"\s*\/\/\s*TODO\(https:\/\/issues.apache.org\/jira\/browse\/BEAM-10402\)\s*$/d'
**/test/**/*.java
# Run spotless, then remove empty SuppressWarnings annotations
./gradlew spotlessApply
sed -Ei '/@SuppressWarnings\(\{\}\)/d' **/test/**/*.java
```
Then I ran `grep -IirnEl 'BEAM-10402' **/test/**/*.java` to identify the
last ~10 that needed to be cleaned up manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558634)
Time Spent: 2h 10m (was: 2h)
> Nullness checks are excessive for test classes
> ----------------------------------------------
>
> Key: BEAM-11436
> URL: https://issues.apache.org/jira/browse/BEAM-11436
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Labels: stale-assigned
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> We don't have checkerframework nullness annotations for JUnit, which often
> leads to difficult nullness errors. The most onerous is that assertNotNull
> requires the argument to be NonNull already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
