[ 
https://issues.apache.org/jira/browse/BEAM-11833?focusedWorklogId=558966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558966
 ]

ASF GitHub Bot logged work on BEAM-11833:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Feb/21 19:29
            Start Date: 27/Feb/21 19:29
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #14013:
URL: https://github.com/apache/beam/pull/14013#issuecomment-783335600


   # [Codecov](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=h1) Report
   > Merging 
[#14013](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=desc) (aaad864) 
into 
[master](https://codecov.io/gh/apache/beam/commit/c758a0d68d881df40e80f61691315b6f0222008f?el=desc)
 (c758a0d) will **increase** coverage by `0.02%`.
   > The diff coverage is `92.33%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/14013/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14013      +/-   ##
   ==========================================
   + Coverage   82.95%   82.98%   +0.02%     
   ==========================================
     Files         469      469              
     Lines       58343    58298      -45     
   ==========================================
   - Hits        48401    48379      -22     
   + Misses       9942     9919      -23     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
 | `93.95% <ø> (-0.04%)` | :arrow_down: |
   | 
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
 | `79.61% <16.66%> (-0.39%)` | :arrow_down: |
   | 
[...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==)
 | `92.03% <42.85%> (-1.65%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/internal/pickler.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvcGlja2xlci5weQ==)
 | `86.86% <80.00%> (ø)` | |
   | 
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
 | `90.80% <88.05%> (-0.28%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/transforms/stats.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zdGF0cy5weQ==)
 | `97.33% <97.91%> (+10.61%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=)
 | `90.50% <100.00%> (-0.05%)` | :arrow_down: |
   | 
[...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==)
 | `89.92% <100.00%> (ø)` | |
   | 
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
 | `88.09% <0.00%> (-7.15%)` | :arrow_down: |
   | 
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
 | `91.91% <0.00%> (-2.21%)` | :arrow_down: |
   | ... and [6 
more](https://codecov.io/gh/apache/beam/pull/14013/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=footer). Last 
update 
[c758a0d...db6dd9b](https://codecov.io/gh/apache/beam/pull/14013?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 558966)
    Time Spent: 4h 50m  (was: 4h 40m)

> UnboundedSourceAsSDFRestrictionTracker reports incorrect watermark after 
> failed claim
> -------------------------------------------------------------------------------------
>
>                 Key: BEAM-11833
>                 URL: https://issues.apache.org/jira/browse/BEAM-11833
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>    Affects Versions: 2.28.0
>            Reporter: Jan Lukavský
>            Assignee: Jan Lukavský
>            Priority: P1
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> After being split by call to {{trySplit}}, the watermark reported by 
> {{UnboundedSourceAsSDFRestrictionTracker.currentRestriction().getWatermark()}}
>  is BoundedWindow.TIMESTAMP_MAX_VALUE, which is incorrect.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to