[ 
https://issues.apache.org/jira/browse/BEAM-11659?focusedWorklogId=559176&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-559176
 ]

ASF GitHub Bot logged work on BEAM-11659:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/21 03:55
            Start Date: 01/Mar/21 03:55
    Worklog Time Spent: 10m 
      Work Description: dpcollins-google commented on a change in pull request 
#13920:
URL: https://github.com/apache/beam/pull/13920#discussion_r584431988



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -949,6 +950,40 @@ public int hashCode() {
             getMetadata()
           });
     }
+
+    @Override
+    public String toString() {

Review comment:
       This is FieldType, without it, its just a dump of all the fields in a 
json-ish structure, which makes it hard to determine at a glance what is going 
on in debug prints, and makes it not a great method to present to end users 
when saying "this field is badly formatted". This makes the output very similar 
to the DDL you would have to type to describe a field of this type.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 559176)
    Time Spent: 18h  (was: 17h 50m)

> Integrate Pub/Sub Lite with beam SQL
> ------------------------------------
>
>                 Key: BEAM-11659
>                 URL: https://issues.apache.org/jira/browse/BEAM-11659
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql, io-java-gcp
>            Reporter: Daniel Collins
>            Assignee: Daniel Collins
>            Priority: P2
>          Time Spent: 18h
>  Remaining Estimate: 0h
>
> Pub/Sub Lite should be a valid source and sink for beam SQL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to