[jira] [Work logged] (BEAM-11436) Nullness checks are excessive for test classes

Tue, 02 Mar 2021 17:15:05 -0800 


     [ 
https://issues.apache.org/jira/browse/BEAM-11436?focusedWorklogId=560241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560241
 ]

ASF GitHub Bot logged work on BEAM-11436:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Mar/21 01:14
            Start Date: 03/Mar/21 01:14
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #14101:
URL: https://github.com/apache/beam/pull/14101#issuecomment-786366287


   # [Codecov](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=h1) Report
   > Merging 
[#14101](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=desc) (c159f45) 
into 
[master](https://codecov.io/gh/apache/beam/commit/7a27c790a49a16e5476ec624887f3ed08012fc28?el=desc)
 (7a27c79) will **increase** coverage by `0.37%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/14101/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14101      +/-   ##
   ==========================================
   + Coverage   83.04%   83.42%   +0.37%     
   ==========================================
     Files         469      469              
     Lines       58465    60259    +1794     
   ==========================================
   + Hits        48555    50271    +1716     
   - Misses       9910     9988      +78     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[...sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9pbnRlcm5hbC9tZXRyaWNzL21ldHJpYy5weQ==)
 | `86.45% <0.00%> (-1.05%)` | :arrow_down: |
   | 
[...apache\_beam/portability/api/beam\_runner\_api\_pb2.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9wb3J0YWJpbGl0eS9hcGkvYmVhbV9ydW5uZXJfYXBpX3BiMi5weQ==)
 | `100.00% <0.00%> (ø)` | |
   | 
[...sdks/python/apache\_beam/transforms/environments.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL2Vudmlyb25tZW50cy5weQ==)
 | `85.32% <0.00%> (+0.13%)` | :arrow_up: |
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9idW5kbGVfcHJvY2Vzc29yLnB5)
 | `94.40% <0.00%> (+0.41%)` | :arrow_up: |
   | 
[...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L2ZuX2FwaV9ydW5uZXIvZXhlY3V0aW9uLnB5)
 | `95.14% <0.00%> (+1.45%)` | :arrow_up: |
   | 
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3dvcmtlci9kYXRhX3BsYW5lLnB5)
 | `91.31% <0.00%> (+1.79%)` | :arrow_up: |
   | 
[...ild/srcs/sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2NvbW1vbi5weQ==)
 | `90.63% <0.00%> (+1.91%)` | :arrow_up: |
   | 
[...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL3BvcnRhYmlsaXR5L2ZuX2FwaV9ydW5uZXIvZm5fcnVubmVyLnB5)
 | `92.10% <0.00%> (+2.23%)` | :arrow_up: |
   | 
[...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93X3J1bm5lci5weQ==)
 | `84.94% <0.00%> (+2.65%)` | :arrow_up: |
   | 
[...rcs/sdks/python/apache\_beam/transforms/timeutil.py](https://codecov.io/gh/apache/beam/pull/14101/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0NvbW1pdC9zcmMvc2Rrcy9weXRob24vdGVzdC1zdWl0ZXMvdG94L3B5MzgvYnVpbGQvc3Jjcy9zZGtzL3B5dGhvbi9hcGFjaGVfYmVhbS90cmFuc2Zvcm1zL3RpbWV1dGlsLnB5)
 | `98.88% <0.00%> (+3.43%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=footer). Last 
update 
[8c6904d...c159f45](https://codecov.io/gh/apache/beam/pull/14101?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 560241)
    Time Spent: 7h 40m  (was: 7.5h)

> Nullness checks are excessive for test classes
> ----------------------------------------------
>
>                 Key: BEAM-11436
>                 URL: https://issues.apache.org/jira/browse/BEAM-11436
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: P2
>              Labels: stale-assigned
>          Time Spent: 7h 40m
>  Remaining Estimate: 0h
>
> We don't have checkerframework nullness annotations for JUnit, which often 
> leads to difficult nullness errors. The most onerous is that assertNotNull 
> requires the argument to be NonNull already.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to