[
https://issues.apache.org/jira/browse/BEAM-6634?focusedWorklogId=196748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196748
]
ASF GitHub Bot logged work on BEAM-6634:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/19 23:46
Start Date: 10/Feb/19 23:46
Worklog Time Spent: 10m
Work Description: adude3141 commented on pull request #7788: [BEAM-6634]
apply base plugin to flink_job_server_container.gradle to…
URL: https://github.com/apache/beam/pull/7788#discussion_r255363044
##########
File path: runners/flink/job-server-container/flink_job_server_container.gradle
##########
@@ -23,6 +23,7 @@
*/
apply plugin: 'org.apache.beam.module'
+apply plugin: 'base'
Review comment:
see failure on PR https://github.com/apache/beam/pull/7787 python_PreCommit
https://scans.gradle.com/s/7vd7a5pylnrmu
Running `./gradlew -p runners/flink/job-server-container/
copyDockerfileDependencies`
with gradle 5.0 gives a different error message
> FAILURE: Build failed with an exception.
What went wrong:
Could not determine the dependencies of task
':beam-runners-flink_2.11-job-server-container:copyDockerfileDependencies'.
Could not resolve all dependencies for configuration
':beam-runners-flink_2.11-job-server-container:dockerDependency'.
The destinationDir property must be set. Please apply the base plugin or
set it explicitly.
The destinantionDIr property is missing on some abstractarchivetask, which
is handled by the base plugin. I honestly do not yet fully understand the
changes caused by that provider api. To much internal magic going on which I do
not fully understand, unfortunately. I just trust gradle in what it is telling
me...
I m unsure, whether this is a problem caused by beams crossreferencing
setup, which is more complex than 'usual' gradle projects. Or it might be some
issue with gradle itself. AFAIU, the provider api is rather new and might have
some edges causing trouble here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196748)
Time Spent: 1h 10m (was: 1h)
> Fix "Run Portable_Python PreCommit" for gradle 5
> ------------------------------------------------
>
> Key: BEAM-6634
> URL: https://issues.apache.org/jira/browse/BEAM-6634
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {no format}
> 16:09:03 FAILURE: Build failed with an exception.
> 16:09:03
> 16:09:03 * What went wrong:
> 16:09:03 Could not determine the dependencies of task
> ':beam-runners-flink_2.11-job-server-container:copyDockerfileDependencies'.
> 16:09:03 > Could not resolve all dependencies for configuration
> ':beam-runners-flink_2.11-job-server-container:dockerDependency'.
> 16:09:03 > No value has been specified for this provider.
> {no format}
> We need to apply the base plugin.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
