[
https://issues.apache.org/jira/browse/BEAM-6640?focusedWorklogId=196869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-196869
]
ASF GitHub Bot logged work on BEAM-6640:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/19 10:08
Start Date: 11/Feb/19 10:08
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7798: [BEAM-6640]
Restore portable Flink pipeline trimming
URL: https://github.com/apache/beam/pull/7798#discussion_r255440761
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobInvocation.java
##########
@@ -133,8 +133,8 @@ PipelineResult
runPipelineWithTranslator(FlinkPortablePipelineTranslator<T> tran
RunnerApi.Pipeline fusedPipeline =
trimmedPipeline.getComponents().getTransformsMap().values().stream()
.anyMatch(proto ->
ExecutableStage.URN.equals(proto.getSpec().getUrn()))
- ? pipeline
- : GreedyPipelineFuser.fuse(pipeline).toPipeline();
+ ? trimmedPipeline
+ : GreedyPipelineFuser.fuse(trimmedPipeline).toPipeline();
Review comment:
Thanks for spotting. Looks like a bug caused by rebasing to the latest
master.
CC @robertwb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 196869)
Time Spent: 0.5h (was: 20m)
> Reshuffle not translated to Flink rebalance
> -------------------------------------------
>
> Key: BEAM-6640
> URL: https://issues.apache.org/jira/browse/BEAM-6640
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: portability-flink
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Flink runner as of 2.10 uses native rebalance to implement reshuffle, this is
> broken in master and leads to performance degradation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
