[
https://issues.apache.org/jira/browse/BEAM-1850?focusedWorklogId=561446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561446
]
ASF GitHub Bot logged work on BEAM-1850:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/21 15:28
Start Date: 05/Mar/21 15:28
Worklog Time Spent: 10m
Work Description: dmvk closed pull request #13540:
URL: https://github.com/apache/beam/pull/13540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 561446)
Time Spent: 40m (was: 0.5h)
> Improve interplay between PushbackSideInputRunner and
> GroupAlsoByWindowViaWindowSetDoFn
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-1850
> URL: https://issues.apache.org/jira/browse/BEAM-1850
> Project: Beam
> Issue Type: Improvement
> Components: runner-core, runner-flink
> Reporter: Aljoscha Krettek
> Priority: P3
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This originated from a discussion on a PR:
> https://github.com/apache/beam/pull/2235
> {{GroupAlsoByWindowViaWindowSetDoFn}}/{{GroupAlsoByWindowViaWindowSetNewDoFn}}
> and {{PushbackSideInputDoFnRunner}} don't work well together and we manually
> need to explode windows in
> {{FlinkStreamingTransformTranslators.ToKeyedWorkItem}} because of this:
> - {{GroupAlsoByWindowViaWindowSetDoFn}} is a {{DoFn<KeyedWorkItem<K,
> InputT>, KV<K, OutputT>>}} so you have to push in {{KeyedWorkItem}}. These
> themselves contain {{WindowedValue<InputT>}} (or timers).
> - For executing a {{DoFn}} we use a {{DoFnRunner}}. For our problem the
> interesting case is using a {{PushbackSideInputDoFnRunner}}. The interesting
> method is {{processElementInReadyWindows(WindowedValue<InputT> elem)}} where
> {{InputT}} is the input type of the {{DoFn}} which, for the windowing case,
> is {{KeyedWorkItem<K, InputT>}} (from above). The actual expanded type
> signature is thus
> {{processElementInReadyWindows(WindowedValue<KeyedWorkItem<K, InputT>>
> elem)}} where the keyed work items again contain {{WindowedValues}} (again,
> from above).
> I think the {{PushbackSideInputDoFnRunner}} was not initially meant for
> executing {{GroupAlsoByWindowViaWindowSetDoFns}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
