[
https://issues.apache.org/jira/browse/BEAM-11932?focusedWorklogId=562432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562432
]
ASF GitHub Bot logged work on BEAM-11932:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/21 16:07
Start Date: 08/Mar/21 16:07
Worklog Time Spent: 10m
Work Description: tysonjh commented on a change in pull request #14162:
URL: https://github.com/apache/beam/pull/14162#discussion_r589543640
##########
File path: sdks/python/apache_beam/options/pipeline_options_test.py
##########
@@ -623,6 +623,17 @@ def test_transform_name_mapping(self):
mapping = options.view_as(GoogleCloudOptions).transform_name_mapping
self.assertEqual(mapping['from'], 'to')
+ def test_service_options(self):
+ options = PipelineOptions(['--service_option', 'whizz=bang',
'--service_option', 'beep=boop'])
+ self.assertEqual(
+ sorted(options.get_all_options()['service_options']), ['beep=boop',
'whizz=bang'])
+
+ options = PipelineOptions(['--service_options', 'whizz=bang',
'--service_options', 'beep=boop'])
+ self.assertEqual(
+ sorted(options.get_all_options()['service_options']), ['beep=boop',
'whizz=bang'])
Review comment:
`sorted(options.get_all_options()['service_options']), ['beep=boop',
'whizz=bang'])` is the same. The `PipelineOptions` are configured once using
repeated `service_option` (i.e. singular) flags, and once using
`service_options` (i.e. plural).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 562432)
Time Spent: 5h 40m (was: 5.5h)
> ServiceOptions for configuring Dataflow
> ---------------------------------------
>
> Key: BEAM-11932
> URL: https://issues.apache.org/jira/browse/BEAM-11932
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Tyson Hamilton
> Assignee: Tyson Hamilton
> Priority: P2
> Fix For: 2.29.0
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> Introduce a new pipeline option for configuring the Dataflow Service. The
> option is specifically to decouple a service side feature from the Apache
> Beam release cycle. This allows a service feature to support previously
> released Apache Beam SDKs prior to a first-class pipeline option being
> introduced (as part of the normal feature lifecycle).
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
