[ 
https://issues.apache.org/jira/browse/BEAM-5628?focusedWorklogId=563736&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-563736
 ]

ASF GitHub Bot logged work on BEAM-5628:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Mar/21 13:34
            Start Date: 10/Mar/21 13:34
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] commented on pull request #14185:
URL: https://github.com/apache/beam/pull/14185#issuecomment-795419914


   # [Codecov](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=h1) Report
   > Merging 
[#14185](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=desc) (a9f6c5f) 
into 
[master](https://codecov.io/gh/apache/beam/commit/ae5e1a31085302afcba8971db50d3bc554bcd2e2?el=desc)
 (ae5e1a3) will **increase** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/14185/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14185      +/-   ##
   ==========================================
   + Coverage   83.13%   83.29%   +0.16%     
   ==========================================
     Files         469      468       -1     
     Lines       58880    58687     -193     
   ==========================================
   - Hits        48947    48884      -63     
   + Misses       9933     9803     -130     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[...hon/apache\_beam/runners/direct/direct\_userstate.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZGlyZWN0X3VzZXJzdGF0ZS5weQ==)
 | | |
   | 
[.../srcs/sdks/python/apache\_beam/typehints/opcodes.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL29wY29kZXMucHk=)
 | | |
   | 
[...srcs/sdks/python/apache\_beam/coders/avro\_record.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2F2cm9fcmVjb3JkLnB5)
 | | |
   | 
[...sdks/python/apache\_beam/ml/gcp/visionml\_test\_it.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvZ2NwL3Zpc2lvbm1sX3Rlc3RfaXQucHk=)
 | | |
   | 
[...amples/snippets/transforms/elementwise/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvc25pcHBldHMvdHJhbnNmb3Jtcy9lbGVtZW50d2lzZS9fX2luaXRfXy5weQ==)
 | | |
   | 
[...rcs/sdks/python/apache\_beam/testing/test\_stream.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbS5weQ==)
 | | |
   | 
[.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5)
 | | |
   | 
[...ache\_beam/runners/interactive/pipeline\_fragment.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9waXBlbGluZV9mcmFnbWVudC5weQ==)
 | | |
   | 
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
 | | |
   | 
[...eam/runners/interactive/options/capture\_control.py](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree#diff-YmVhbV9QcmVDb21taXRfUHl0aG9uX0Nyb24vc3JjL3Nka3MvcHl0aG9uL3Rlc3Qtc3VpdGVzL3RveC9weTM4L2J1aWxkL3NyY3Mvc2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfY29udHJvbC5weQ==)
 | | |
   | ... and [927 
more](https://codecov.io/gh/apache/beam/pull/14185/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=footer). Last 
update 
[ae5e1a3...a9f6c5f](https://codecov.io/gh/apache/beam/pull/14185?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 563736)
    Time Spent: 20m  (was: 10m)

> VcfIO is not Python3-compatible and there are no plans to make it compatible.
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-5628
>                 URL: https://issues.apache.org/jira/browse/BEAM-5628
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Priority: P3
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Several VcfIO tests fail in Python 3 with TypeError: cannot use a string 
> pattern on a bytes-like object
>  
> ERROR: test_read_after_splitting (apache_beam.io.vcfio_test.VcfSourceTest)
>  "
>  ----------------------------------------------------------------------
>  Traceback (most recent call last):
>  File 
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/vcfio_test.py"",
>  line 336, in test_read_after_splitting
>  ] split_records.extend(source_test_utils.read_from_source(*source_info))
>  ] File 
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/source_test_utils.py"",
>  line 101, in read_from_source
>  for value in reader:
>  File 
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/vcfio.py"",
>  line 264, in read_records
>  for line in record_iterator:
>  File 
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/io/vcfio.py"",
>  line 330, in __next__
>  record = next(self._vcf_reader)
>  File 
> ""/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/target/.tox/py3/lib/python3.5/site-packages/vcf/parser.py"",
>  line 543, in __next__
>  row = self._row_pattern.split(line.rstrip())
>  TypeError: cannot use a string pattern on a bytes-like object
>  "



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to