[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=564095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564095
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/21 22:12
Start Date: 10/Mar/21 22:12
Worklog Time Spent: 10m
Work Description: shehzaadn-vd commented on a change in pull request
#13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r591902472
##########
File path: runners/google-cloud-dataflow-java/worker/build.gradle
##########
@@ -86,24 +86,32 @@ dependencies {
compile google_api_services_dataflow
compile library.java.avro
compile library.java.google_api_client
+ permitUnusedDeclared library.java.google_api_client // BEAM-11761
+ compile library.java.google_auth_library_credentials
compile library.java.google_http_client
compile library.java.google_http_client_jackson2
compile library.java.jackson_annotations
compile library.java.jackson_core
compile library.java.jackson_databind
compile library.java.joda_time
+ compile library.java.proto_google_common_protos
shadow library.java.vendored_guava_26_0_jre
Review comment:
@ibzib, is there a way to avoid having both:
`shadow library.java.vendored_guava_26_0_jre`
and
`compile "com.google.guava:guava:25.1-jre"`
I mean can we have only one line for guava?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 564095)
Time Spent: 182h (was: 181h 50m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 182h
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
