[
https://issues.apache.org/jira/browse/BEAM-11715?focusedWorklogId=564827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-564827
]
ASF GitHub Bot logged work on BEAM-11715:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/21 18:39
Start Date: 11/Mar/21 18:39
Worklog Time Spent: 10m
Work Description: yifanmai commented on a change in pull request #14193:
URL: https://github.com/apache/beam/pull/14193#discussion_r592616137
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -494,11 +494,7 @@ def run_pipeline(self, pipeline, options):
if pre_optimize == 'none' or pre_optimize == 'default':
phases = []
elif pre_optimize == 'all':
- phases = [
- # TODO(BEAM-11694): Enable translations.pack_combiners
- # translations.pack_combiners,
- translations.sort_stages
- ]
+ phases = [translations.pack_combiners, translations.sort_stages]
Review comment:
Is it safe to enable combiner packing for Dataflow now, or do we need to
wait for Dataflow's backend to support CombinePerKeys without subtransforms
first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 564827)
Time Spent: 12h 20m (was: 12h 10m)
> Combiner packing creates an incorrect proto
> -------------------------------------------
>
> Key: BEAM-11715
> URL: https://issues.apache.org/jira/browse/BEAM-11715
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Yifan Mai
> Priority: P1
> Fix For: 2.28.0
>
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> Seems like optimization creates a CombinePerKey transform that does not have
> any sub-transforms. We should fix this by preserving the old structure for
> CombinePerKey (GBK+CombineValues composite).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
