[
https://issues.apache.org/jira/browse/BEAM-3306?focusedWorklogId=197162&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197162
]
ASF GitHub Bot logged work on BEAM-3306:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/19 21:10
Start Date: 11/Feb/19 21:10
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #7812: [BEAM-3306]
Hash keys when lifting
URL: https://github.com/apache/beam/pull/7812
Hash key values when combiner lifting using the registered coder for the
type.
Specialized for numeric primitive types to avoid unnecessary work.
This turns out to be faster than the general "interface{}" hashing we had
previously for numeric type, and is comparable, but marginally slower than
native maps with the primitive numeric type as keys.
Strings are currently much slower as keys than the native go runtime
approach for interfaces{}, as the runtime uses a better hash function.
General struct performance (for values Go supported as keys) will be much
slower than the go runtime.
Pointer elements (with coders) used as keys will be slower, but they'll also
be correct, which wasn't the case previously.
Care needs to be taken using Maps in Key values, as the Go SDK does not
presently sort maps in any fashion prior to encoding. Combined with go map's
random iteration order, means combines with such keys will not be valid.
A separate in PR will add vetting for this case, to discourage the use of
map fields in key types.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 197162)
Time Spent: 2h (was: 1h 50m)
> Consider: Go coder registry
> ---------------------------
>
> Key: BEAM-3306
> URL: https://issues.apache.org/jira/browse/BEAM-3306
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Minor
> Labels: triaged
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Add coder registry to allow easier overwrite of default coders. We may also
> allow otherwise un-encodable types, but that would require that function
> analysis depends on it.
> If we're hardcoding support for proto/avro, then there may be little need for
> such a feature. Conversely, this may be how we implement such support.
>
> Proposal Doc:
> [https://docs.google.com/document/d/1kQwx4Ah6PzG8z2ZMuNsNEXkGsLXm6gADOZaIO7reUOg/edit#|https://docs.google.com/document/d/1kQwx4Ah6PzG8z2ZMuNsNEXkGsLXm6gADOZaIO7reUOg/edit]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
